3798 When deleting data pill in the mention input, '@' shows up instead of '$'

[ivicac]

• 3798 client - Fix when deleting data pill in the mention input, '@' shows up instead of '$'
• 0 client - Remove "@tiptap/*" from npm reject list in .ncurc.json

[Copilot]

Pull request overview

This PR fixes an issue where deleting a data pill (mention) in the mention input leaves behind an '@' character instead of the expected '$' character. The fix adds a custom ProseMirror plugin that intercepts transactions and replaces '@' with '$' when detected. Additionally, the PR improves ref handling by using useEffect and removes "@tiptap/*" from the npm reject list to allow tiptap package updates.

Key Changes

• Adds a MentionBackspaceFix ProseMirror plugin that detects and replaces '@' characters with '$' after mention deletion
• Refactors ref assignment to use React's useEffect hook for proper lifecycle management
• Adds comprehensive test coverage for the backspace behavior across TEXT, TEXT_AREA, and RICH_TEXT control types

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
PropertyMentionsInputEditor.tsx	Adds Plugin import, implements MentionBackspaceFix extension, and refactors ref handling to use useEffect
PropertyMentionsInput.test.tsx	Adds test coverage for backspace behavior with mentions across different control types
.ncurc.json	Removes "@tiptap/*" from npm upgrade reject list to allow tiptap package updates

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[kresimir-coko]

Moran ovo sam isprobati, ne sviđa mi se ova implementacija nikako

[kresimir-coko]

@ivicac Nikako mi se ne sviđa ova implementacija, izgleda mi prekompleksno za ono šta postiže. Plus, ovo je nekakav bug radi nove verzije, nismo imali ovaj problem prije.

Jel ti okej da dodamo deleteTriggerWithBackspace: true tako da se samo izbriše trigger ($ ili @) kad se obriše datapill? Barem za prvu ruku dok ne smislimo pametnije rješenje (ili tiptap popravi bug)

[sonarqubecloud]

Quality Gate passed for 'client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud