Skip to content

3798 When deleting data pill in the mention input, '@' shows up instead of '$' #3799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivicac merged 6 commits into from
Dec 28, 2025
+2 −1
Merged

3798 When deleting data pill in the mention input, '@' shows up instead of '$' #3799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7da6183
3798 client - Replace ‘@’ with ‘$’ when deleting data pill in the men…
ivicac Dec 23, 2025
4f7d005
3798 client - Add test
ivicac Dec 23, 2025
e938981
0 client - Remove "@tiptap/*" from npm reject list in .ncurc.json
ivicac Dec 21, 2025
f3384c4
Revert "3798 client - Add test"
ivicac Dec 28, 2025
238b4cd
Revert "3798 client - Replace ‘@’ with ‘$’ when deleting data pill in…
ivicac Dec 28, 2025
627c02f
3798 client - Enable backspace trigger for deleting mentions in Prope…
ivicac Dec 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/.ncurc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"reject": ["@tiptap/*", "@types/node", "tailwindcss"]
"reject": ["@types/node", "tailwindcss"]
}
1 change: 1 addition & 0 deletions .../components/properties/components/property-mentions-input/PropertyMentionsInputEditor.tsx
View file
Open in desktop
Copy link
Collaborator

@kresimir-coko kresimir-coko Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivicac Nikako mi se ne sviđa ova implementacija, izgleda mi prekompleksno za ono šta postiže. Plus, ovo je nekakav bug radi nove verzije, nismo imali ovaj problem prije.

Jel ti okej da dodamo deleteTriggerWithBackspace: true tako da se samo izbriše trigger ($ ili @) kad se obriše datapill? Barem za prvu ruku dok ne smislimo pametnije rješenje (ili tiptap popravi bug)

Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ const PropertyMentionsInputEditor = forwardRef<Editor, PropertyMentionsInputEdit
HTMLAttributes: {
class: 'property-mention',
},
deleteTriggerWithBackspace: true,
renderHTML({node, options}) {
const svg = getComponentIcon(node.attrs.label ?? node.attrs.id);

Expand Down
Loading