Revise and expand on C/C++ language support section #298
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| #include "adder.h" | ||
|
|
||
| uint32_t exports_docs_adder_add_add(uint32_t x, uint32_t y) | ||
| { | ||
| return x + y; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -0,0 +1,9 @@ | ||||
| #include "adder.h" | ||||
| #include <stdio.h> | ||||
|
|
||||
| uint32_t exports_docs_adder_add_add(uint32_t x, uint32_t y) | ||||
| { | ||||
| uint32_t result = x + y; | ||||
| printf("%d", result); | ||||
|
There was a problem hiding this comment.
Suggested change
We can probably get rid of the There was a problem hiding this comment. I think the point of including the example that uses There was a problem hiding this comment. Ahh thank you sorry I lost this context. This would be fine as-is, but what do you think about adding a comment here? Above the I'm thinking of a note like: // On traditional platforms, printf() prints to stdout, but on Wasm platforms
// stdout and the idea of printing to output stream is introduced and managed by
// WASI.
//
// When building this code with wasi-libc (as a part of wasi-sdk), the printf call
// below is replaced with code that uses `wasi:cli/stdout` and `wasi:io/streams`. |
||||
| return result; | ||||
| } | ||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've quite intentionally avoided putting other tutorial examples inside this codebase, but I'm thinking we should reconsider that. I'd personally like to see all code we put in the language guides hosted in component-docs so we can at least test them via CI.
That said, this has come up and we decided against it -- maybe I'm misremembering.
Thoughts @itowlson , @kate-goldenring ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that was my thought -- that if the code examples were in separate files, they could eventually be tested in CI.