Add support for non-Docker build tools (e.g., podman)
#288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some machines (e.g., Fedora-based) do not make it easy to use Docker tooling for building containers. In these environments, `podman` is a workable replacement. This change allows using replacing the use of `docker` with something like: `DOCKER=podman benchmarks/build-all.sh`.
Member
Author
|
The build failure here should be resolved in #289. |
jlb6740
reviewed
Jun 20, 2025
Collaborator
jlb6740
left a comment
jlb6740
left a comment
There was a problem hiding this comment.
Just one comment. Otherwise approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some machines (e.g., Fedora-based) do not make it easy to use Docker tooling for building containers. In these environments,
podmanis a workable replacement. This change allows using replacing the use ofdockerwith something like:DOCKER=podman benchmarks/build-all.sh.