Skip to content

Add support for non-Docker build tools (e.g., podman) #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abrown merged 3 commits into from
Jun 21, 2025
Merged

Add support for non-Docker build tools (e.g., podman) #288

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a699c48
Add support for non-Docker build tools (e.g., `podman`)
abrown Jun 17, 2025
99bab49
Merge branch 'main' into podman
abrown Jun 17, 2025
4741323
Fix typo
abrown Jun 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions benchmarks/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ if [[ ! -d $BENCHMARK_DIR ]]; then
exit 1
fi

DOCKER=${DOCKER:-docker}
BENCHMARK_NAME=$(readlink -f $BENCHMARK_DIR | xargs basename)
IMAGE_NAME=sightglass-benchmark-$BENCHMARK_NAME
TMP_BENCHMARK=$(mktemp -d /tmp/sightglass-benchmark-XXXXXX)
Expand All @@ -34,9 +35,9 @@ TMP_TAR=$(mktemp /tmp/sightglass-benchmark-dir-XXXXXX.tar)

# Build the benchmark image and extract the generated `benchmark.wasm` file from its container.
print_header "Build benchmarks"
(set -x; docker build --tag $IMAGE_NAME - < $TMP_TAR)
CONTAINER_ID=$(set -x; docker create $IMAGE_NAME)
(set -x; docker cp $CONTAINER_ID:/benchmark/. $TMP_BENCHMARK)
(set -x; $DOCKER build --tag $IMAGE_NAME - < $TMP_TAR)
CONTAINER_ID=$(set -x; $DOCKER create $IMAGE_NAME)
(set -x; $DOCKER cp $CONTAINER_ID:/benchmark/. $TMP_BENCHMARK)

# Verify benchmark is a valid Sightglass benchmark.
print_header "Verify benchmark"
Expand All @@ -52,6 +53,6 @@ done;
print_header "Clean up"
(set -x; rm $TMP_TAR)
(set -x; rm -rf $TMP_BENCHMARK)
(set -x; docker rm $CONTAINER_ID)
# We do not remove the image and intermediate images here (e.g., `docker rmi $IMAGE_NAME`) to speed
(set -x; $DOCKER rm $CONTAINER_ID)
# We do not remove the image and intermediate images here (e.g., `$DOCKER rmi $IMAGE_NAME`) to speed
# up `build-all.sh`; use `clean.sh` instead.