Skip to content

fix: use atomic writes for FileCache to prevent race conditions #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Gosorasora wants to merge 1 commit into from
+16 −5
Closed

fix: use atomic writes for FileCache to prevent race conditions #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions crates/wasm-pkg-client/src/caching/file.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,25 @@ impl From<ReleaseInfoOwned> for Release {
impl Cache for FileCache {
async fn put_data(&self, digest: ContentDigest, data: ContentStream) -> Result<(), Error> {
let path = self.root.join(digest.to_string());
let mut file = tokio::fs::File::create(&path).await.map_err(|e| {
Error::CacheError(anyhow::anyhow!("Unable to create file for cache {e}"))
})?;
let temp_path = self.root.join(format!("{}.tmp.{}", digest, std::process::id()));

let mut file = tokio::fs::File::create(&temp_path)
.await
.map_err(|e| Error::CacheError(e.into()))?;
let mut buf = StreamReader::new(data.map_err(std::io::Error::other));
tokio::io::copy(&mut buf, &mut file)
.await
.map_err(|e| Error::CacheError(e.into()))
.map(|_| ())
.map_err(|e| Error::CacheError(e.into()))?;
file.sync_all()
.await
.map_err(|e| Error::CacheError(e.into()))?;
drop(file);

tokio::fs::rename(&temp_path, &path)
.await
.map_err(|e| Error::CacheError(e.into()))?;

Ok(())
}

async fn get_data(&self, digest: &ContentDigest) -> Result<Option<ContentStream>, Error> {
Expand Down
Loading