Skip to content

Update F128 argument ABI for windows_fastcall to match LLVM 21 #10678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

Update F128 argument ABI for windows_fastcall to match LLVM 21 #10678

merged 1 commit into from
Apr 28, 2025

Conversation

@beetrees
Copy link
Contributor

@beetrees beetrees commented Apr 26, 2025 •
edited
Loading

LLVM updated the windows_fastcall ABI for f128 in llvm/llvm-project#128848 to be passed indirectly (like __m128i), as that is more consistent with the rest of the windows_fastcall ABI. This PR updates Cranelift to match (f128 can only be used with windows_fastcall in Cranelift with enable_llvm_abi_extensions).

@beetrees beetrees requested a review from a team as a code owner April 26, 2025 15:23
@beetrees beetrees requested review from fitzgen and removed request for a team April 26, 2025 15:23
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:x64 Issues related to x64 codegen labels Apr 26, 2025
fitzgen
fitzgen approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fitzgen fitzgen added this pull request to the merge queue Apr 28, 2025
Merged via the queue into bytecodealliance:main with commit 41e87be Apr 28, 2025
53 checks passed
@beetrees beetrees deleted the f128-windows-abi branch April 28, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees

No one assigned

Labels

cranelift:area:x64 Issues related to x64 codegen cranelift Issues related to the Cranelift code generator

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@beetrees @fitzgen