Add missing QCheck2 float tests and fix QCheck2.Gen.exponential shrinker#382
Merged
jmid merged 6 commits intoc-cube:mainfrom Dec 11, 2025
Merged
Add missing QCheck2 float tests and fix QCheck2.Gen.exponential shrinker#382jmid merged 6 commits intoc-cube:mainfrom
jmid merged 6 commits intoc-cube:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of #367 I discovered that
QCheck2was missing a bunch of expect tests forfloatcompared toQCheck.This PR therefore adds those tests as mostly a copy-paste job.
Adding the tests however turned out to be a good idea, because it revealed that
QCheck2.Gen.exponential(added in 0.23) and the newly addedQCheck2.Gen.float_expfrom #367 (makingexponentialan alias) would shrink toinfinity- not something an end-user would expect of a generator with an exponential distribution...The reason is that integrated shrinking
Gen.maps the shrinking candidate0.toinfinity.To fix it, I've therefore decided to just let
float_exp's resulting generator shrink towards0.rather than having to special-case0.in the mapped function (or as a shrink invariant).The PR documents the situation
QCheck2.mldefinitions to prepare for the fix