Expect test float_exp on negative inputs too#383
Merged
jmid merged 2 commits intoc-cube:mainfrom Dec 11, 2025
Merged
Conversation
jmid
changed the title
float_exp testfloat_exp on negative inputs too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rereading #382, I realized we weren't testing
float_exp/exponentialon a negativefloatparameter.In order to keep things clean with one topic per PR, this separate PR therefore adds an expect test for both
QCheckandQCheck2to exercise both generation and shrinking on negative numbers too.I'm happy to share that this works fine too 🙂