Skip to content

Expect test float_exp on negative inputs too #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmid merged 2 commits into from
Dec 11, 2025
Merged

Expect test float_exp on negative inputs too #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c53e05d
Add expect tests exercising float_exp generation and shrinking with a…
jmid Dec 11, 2025
d50ada4
Update expect test outputs to reflect addition
jmid Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion test/core/QCheck2_expect_test.expected.ocaml4.32
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,12 @@ Test float_exp 10. < Float.pi failed (6 shrink steps):

--- Failure --------------------------------------------------------------------

Test float_exp -10. > -. Float.pi failed (6 shrink steps):

-3.1417780719

--- Failure --------------------------------------------------------------------

Test char never produces 'abcdef' failed (1 shrink steps):

'a'
Expand Down Expand Up @@ -2015,7 +2021,7 @@ Collect results for test float classify:
FP_nan: 2 cases (0.0%)
================================================================================
1 warning(s)
failure (104 tests failed, 3 tests errored, ran 208 tests)
failure (105 tests failed, 3 tests errored, ran 209 tests)
random seed: 153870556

+++ Stats for int_dist_empty_bucket ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Expand Down
8 changes: 7 additions & 1 deletion test/core/QCheck2_expect_test.expected.ocaml4.64
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,12 @@ Test float_exp 10. < Float.pi failed (6 shrink steps):

--- Failure --------------------------------------------------------------------

Test float_exp -10. > -. Float.pi failed (6 shrink steps):

-3.1417780719

--- Failure --------------------------------------------------------------------

Test char never produces 'abcdef' failed (1 shrink steps):

'a'
Expand Down Expand Up @@ -2079,7 +2085,7 @@ Collect results for test float classify:
FP_nan: 2 cases (0.0%)
================================================================================
1 warning(s)
failure (104 tests failed, 3 tests errored, ran 208 tests)
failure (105 tests failed, 3 tests errored, ran 209 tests)
random seed: 153870556

+++ Stats for int_dist_empty_bucket ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Expand Down
8 changes: 7 additions & 1 deletion test/core/QCheck2_expect_test.expected.ocaml5.32
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,12 @@ Test float_exp 10. < Float.pi failed (8 shrink steps):

--- Failure --------------------------------------------------------------------

Test float_exp -10. > -. Float.pi failed (8 shrink steps):

-3.14167640757

--- Failure --------------------------------------------------------------------

Test char never produces 'abcdef' failed (1 shrink steps):

'a'
Expand Down Expand Up @@ -1999,7 +2005,7 @@ Collect results for test float classify:
FP_subnormal: 3 cases (0.1%)
================================================================================
1 warning(s)
failure (104 tests failed, 3 tests errored, ran 208 tests)
failure (105 tests failed, 3 tests errored, ran 209 tests)
random seed: 153870556

+++ Stats for int_dist_empty_bucket ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Expand Down
8 changes: 7 additions & 1 deletion test/core/QCheck2_expect_test.expected.ocaml5.64
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,6 +518,12 @@ Test float_exp 10. < Float.pi failed (8 shrink steps):

--- Failure --------------------------------------------------------------------

Test float_exp -10. > -. Float.pi failed (8 shrink steps):

-3.14167640757

--- Failure --------------------------------------------------------------------

Test char never produces 'abcdef' failed (1 shrink steps):

'a'
Expand Down Expand Up @@ -2061,7 +2067,7 @@ Collect results for test float classify:
FP_subnormal: 3 cases (0.1%)
================================================================================
1 warning(s)
failure (104 tests failed, 3 tests errored, ran 208 tests)
failure (105 tests failed, 3 tests errored, ran 209 tests)
random seed: 153870556

+++ Stats for int_dist_empty_bucket ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Expand Down
5 changes: 5 additions & 0 deletions test/core/QCheck2_tests.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,6 +565,10 @@ module Shrink = struct
Test.make ~name:"float_exp 10. < Float.pi" ~count:1000 ~print:Print.float
(Gen.float_exp 10.) (fun f -> f < Float.pi)

let float_exp_m10_gt_mpi =
Test.make ~name:"float_exp -10. > -. Float.pi" ~count:1000 ~print:Print.float
(Gen.float_exp (-10.)) (fun f -> f > -. Float.pi)

let char_is_never_abcdef =
Test.make ~name:"char never produces 'abcdef'" ~count:1000 ~print:Print.char
Gen.char (fun c -> not (List.mem c ['a';'b';'c';'d';'e';'f']))
Expand Down Expand Up @@ -865,6 +869,7 @@ module Shrink = struct
float_neg_not_nan;
float_neg_not_infinite;
float_exp_10_lt_pi;
float_exp_m10_gt_mpi;
char_is_never_abcdef;
char_printable_is_never_sign;
char_numeral_is_never_less_5;
Expand Down
8 changes: 7 additions & 1 deletion test/core/QCheck_expect_test.expected.ocaml4.32
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,12 @@ Test float_exp 10. < Float.pi failed (2 shrink steps):

--- Failure --------------------------------------------------------------------

Test float_exp -10. > -. Float.pi failed (2 shrink steps):

-4.

--- Failure --------------------------------------------------------------------

Test char never produces 'abcdef' failed (3 shrink steps):

'a'
Expand Down Expand Up @@ -1998,7 +2004,7 @@ Collect results for test float classify:
FP_nan: 2 cases (0.0%)
================================================================================
1 warning(s)
failure (105 tests failed, 3 tests errored, ran 216 tests)
failure (106 tests failed, 3 tests errored, ran 217 tests)
random seed: 153870556

+++ Stats for int_dist_empty_bucket ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Expand Down
8 changes: 7 additions & 1 deletion test/core/QCheck_expect_test.expected.ocaml4.64
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,12 @@ Test float_exp 10. < Float.pi failed (2 shrink steps):

--- Failure --------------------------------------------------------------------

Test float_exp -10. > -. Float.pi failed (2 shrink steps):

-4.

--- Failure --------------------------------------------------------------------

Test char never produces 'abcdef' failed (3 shrink steps):

'a'
Expand Down Expand Up @@ -2032,7 +2038,7 @@ Collect results for test float classify:
FP_nan: 2 cases (0.0%)
================================================================================
1 warning(s)
failure (105 tests failed, 3 tests errored, ran 216 tests)
failure (106 tests failed, 3 tests errored, ran 217 tests)
random seed: 153870556

+++ Stats for int_dist_empty_bucket ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Expand Down
8 changes: 7 additions & 1 deletion test/core/QCheck_expect_test.expected.ocaml5.32
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,6 +459,12 @@ Test float_exp 10. < Float.pi failed (3 shrink steps):

--- Failure --------------------------------------------------------------------

Test float_exp -10. > -. Float.pi failed (3 shrink steps):

-4.

--- Failure --------------------------------------------------------------------

Test char never produces 'abcdef' failed (2 shrink steps):

'a'
Expand Down Expand Up @@ -2009,7 +2015,7 @@ Collect results for test float classify:
FP_subnormal: 3 cases (0.1%)
================================================================================
1 warning(s)
failure (105 tests failed, 3 tests errored, ran 216 tests)
failure (106 tests failed, 3 tests errored, ran 217 tests)
random seed: 153870556

+++ Stats for int_dist_empty_bucket ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Expand Down
8 changes: 7 additions & 1 deletion test/core/QCheck_expect_test.expected.ocaml5.64
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,6 +491,12 @@ Test float_exp 10. < Float.pi failed (3 shrink steps):

--- Failure --------------------------------------------------------------------

Test float_exp -10. > -. Float.pi failed (3 shrink steps):

-4.

--- Failure --------------------------------------------------------------------

Test char never produces 'abcdef' failed (2 shrink steps):

'a'
Expand Down Expand Up @@ -2041,7 +2047,7 @@ Collect results for test float classify:
FP_subnormal: 3 cases (0.1%)
================================================================================
1 warning(s)
failure (105 tests failed, 3 tests errored, ran 216 tests)
failure (106 tests failed, 3 tests errored, ran 217 tests)
random seed: 153870556

+++ Stats for int_dist_empty_bucket ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Expand Down
5 changes: 5 additions & 0 deletions test/core/QCheck_tests.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,6 +650,10 @@ module Shrink = struct
Test.make ~name:"float_exp 10. < Float.pi" ~count:1000
(float_exp 10.) (fun f -> f < Float.pi)

let float_exp_m10_gt_mpi =
Test.make ~name:"float_exp -10. > -. Float.pi" ~count:1000
(float_exp (-10.)) (fun f -> f > -. Float.pi)

let char_is_never_abcdef =
Test.make ~name:"char never produces 'abcdef'" ~count:1000
char (fun c -> not (List.mem c ['a';'b';'c';'d';'e';'f']))
Expand Down Expand Up @@ -944,6 +948,7 @@ module Shrink = struct
float_neg_not_nan;
float_neg_not_infinite;
float_exp_10_lt_pi;
float_exp_m10_gt_mpi;
char_is_never_abcdef;
char_range_is_never_abc;
char_printable_is_never_sign;
Expand Down