-
Notifications
You must be signed in to change notification settings - Fork 141
Introduce CronOverlapPolicy in StartWorkflowOptions from cadence-idl #1425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to update the corresponding types/mapper functions in common/types/shared.go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I plan to land the corresponding change in server first before releasing this.
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we test this e2e with and without setting the policy?
I have tested this locally, I plan to add an integration test later. |
Detailed Description
[In-depth description of the changes made to the interfaces, specifying new fields, removed fields, or modified data structures]
Introduce CronOverlapPolicy in StartWorkflowOptions from cadence-idl.
Also create empty methods for DeleteDomain operation matching update from cadence-idl.
Impact Analysis
Testing Plan
Rollout Plan