Support passing the specified QueryConsistencyLevel #1456
Merged
+12
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Updated mappers for
DescribeWorkflowExecutionRequest
andGetWorkflowExecutionHistoryRequest
.Why?
When implementing the ability to pass QueryConsistencyLevel: Strong on DescribeWorkflowExecution and GetWorkflowExecutionHistory I missed two mappers to convert between proto and thrift objects. This meant that requests passed via the go client did not have the user defined consistency level and passed the default, Invalid.
How did you test it?
Unit tests + tested w/ a local script using the go client against our staging environments.
Potential risks
N/A