Skip to content

Conversation

c-warren
Copy link
Contributor

What changed?

Updated mappers for DescribeWorkflowExecutionRequest and GetWorkflowExecutionHistoryRequest.

Why?

When implementing the ability to pass QueryConsistencyLevel: Strong on DescribeWorkflowExecution and GetWorkflowExecutionHistory I missed two mappers to convert between proto and thrift objects. This meant that requests passed via the go client did not have the user defined consistency level and passed the default, Invalid.

How did you test it?

Unit tests + tested w/ a local script using the go client against our staging environments.

Potential risks

N/A

Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.53%. Comparing base (061b43b) to head (462990c).
⚠️ Report is 1 commits behind head on master.
see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 061b43b...462990c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@c-warren c-warren merged commit b6fc775 into cadence-workflow:master Aug 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants