Skip to content

Support passing the specified QueryConsistencyLevel #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 28, 2025
+12 −6
Merged

Support passing the specified QueryConsistencyLevel #1456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df85924
Support passing the specified QueryConsistencyLevel
c-warren Aug 28, 2025
8f8b4d0
Merge branch 'master' into cwarren-fixqclmappers
c-warren Aug 28, 2025
462990c
update test data
c-warren Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions internal/compatibility/proto/request.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,9 @@ func DescribeWorkflowExecutionRequest(t *shared.DescribeWorkflowExecutionRequest
return nil
}
return &apiv1.DescribeWorkflowExecutionRequest{
Domain: t.GetDomain(),
WorkflowExecution: WorkflowExecution(t.Execution),
Domain: t.GetDomain(),
WorkflowExecution: WorkflowExecution(t.Execution),
QueryConsistencyLevel: QueryConsistencyLevel(t.QueryConsistencyLevel),
}
}

Expand All @@ -104,6 +105,7 @@ func GetWorkflowExecutionHistoryRequest(t *shared.GetWorkflowExecutionHistoryReq
WaitForNewEvent: t.GetWaitForNewEvent(),
HistoryEventFilterType: EventFilterType(t.HistoryEventFilterType),
SkipArchival: t.GetSkipArchival(),
QueryConsistencyLevel: QueryConsistencyLevel(t.QueryConsistencyLevel),
}
}

Expand Down
6 changes: 4 additions & 2 deletions internal/compatibility/testdata/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,8 +443,9 @@ var (
Identity: Identity,
}
DescribeWorkflowExecutionRequest = apiv1.DescribeWorkflowExecutionRequest{
Domain: DomainName,
WorkflowExecution: &WorkflowExecution,
Domain: DomainName,
WorkflowExecution: &WorkflowExecution,
QueryConsistencyLevel: QueryConsistencyLevel,
}
DescribeWorkflowExecutionResponse = apiv1.DescribeWorkflowExecutionResponse{
ExecutionConfiguration: &WorkflowExecutionConfiguration,
Expand Down Expand Up @@ -504,6 +505,7 @@ var (
WaitForNewEvent: true,
HistoryEventFilterType: HistoryEventFilterType,
SkipArchival: true,
QueryConsistencyLevel: QueryConsistencyLevel,
}
GetWorkflowExecutionHistoryResponse = apiv1.GetWorkflowExecutionHistoryResponse{
History: &History,
Expand Down
6 changes: 4 additions & 2 deletions internal/compatibility/thrift/request.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,9 @@ func DescribeWorkflowExecutionRequest(t *apiv1.DescribeWorkflowExecutionRequest)
return nil
}
return &shared.DescribeWorkflowExecutionRequest{
Domain: &t.Domain,
Execution: WorkflowExecution(t.WorkflowExecution),
Domain: &t.Domain,
Execution: WorkflowExecution(t.WorkflowExecution),
QueryConsistencyLevel: QueryConsistencyLevel(t.QueryConsistencyLevel),
}
}

Expand All @@ -106,6 +107,7 @@ func GetWorkflowExecutionHistoryRequest(t *apiv1.GetWorkflowExecutionHistoryRequ
WaitForNewEvent: &t.WaitForNewEvent,
HistoryEventFilterType: EventFilterType(t.HistoryEventFilterType),
SkipArchival: &t.SkipArchival,
QueryConsistencyLevel: QueryConsistencyLevel(t.QueryConsistencyLevel),
}
}

Expand Down