fix: emit ActivityTaskFailedCounter for canceled activities #1466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zawadzkidiana
requested review from
3vilhamster,
Groxx,
demirkayaender,
dkrotx,
jakobht,
shijiesheng and
taylanisikdemir
as code owners
Problem: Customer reported cadence-activity-task-failed metric not emitted when activities fail due to heartbeat timeout. Root cause is context.Canceled errors convert to RespondActivityTaskCanceledRequest, which only emits ActivityTaskCanceledCounter. Solution: Modified reportActivityComplete() and reportActivityCompleteByID() to emit both ActivityTaskCanceledCounter and ActivityTaskFailedCounter when activities are canceled. Cancellations from timeouts are failures from a monitoring perspective. Changes: - internal/internal_task_pollers.go: Added ActivityTaskFailedCounter.Inc(1) in canceled case for both functions Testing: - go build ./internal/... - compiles successfully - go test ./internal - all existing tests pass - go test ./internal/common/metrics - metrics infrastructure verified - Verified ActivityTaskFailedCounter already defined and used for explicit failures (line 71 constants.go, line 1296 internal_task_pollers.go) Backward compatible. No breaking changes to server communication. Signed-off-by: Diana Zawadzki <[email protected]> Signed-off-by: Diana Zawadzki <[email protected]>
zawadzkidiana
force-pushed
the
draft/dzawadzki/investigate-activity-metric-emission
branch
from
764033d to
3e501d8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
zawadzkidiana
changed the title
Contributor
Author
|
Added "fix:" to title to fix Semantic Pull Request Error |
davidporter-id-au
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Customer reported cadence-activity-task-failed metric not emitted when activities fail due to heartbeat timeout. Root cause is context.Canceled errors convert to RespondActivityTaskCanceledRequest, which only emits ActivityTaskCanceledCounter.
Solution:
Modified reportActivityComplete() and reportActivityCompleteByID() to emit both ActivityTaskCanceledCounter and ActivityTaskFailedCounter when activities are canceled. Cancellations from timeouts are failures from a monitoring perspective.
Changes:
Testing:
Backward compatible. No breaking changes to server communication.
What changed?
Why?
How did you test it?
Potential risks