Skip to content

Window management improvements and fixes #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
josuave merged 8 commits into from
Jan 31, 2025
Merged

Window management improvements and fixes #123

josuave merged 8 commits into from
Jan 31, 2025

Conversation

@dremin
Copy link
Collaborator

@dremin dremin commented Jan 31, 2025

Performance improvements:

  • Use new shell hook messages in Win8+ for handling window monitor changes instead of event hook
  • Use new shell hook messages in Win8+ for full-screen app notifications
  • Adapt FullScreenHelper to use new TasksService events instead of a timer on Win8+

Fix handling of the minimize/restore animation:

  • Fixed NativeWindowEx message object passing so that the result value is actually used
  • Fix broken handling of HSHELL_GETMINRECT
  • Added event to ApplicationWindow that shells can handle to provide a button rect when requested that is used for HSHELL_GETMINRECT

Misc:

  • Added some properties to ApplicationWindow to simplify other code
  • Improve FullScreenHelper logic and logging
  • Fix ResetScreenCache on newer .NET versions (Error on FullScreenHelper.ResetScreenCache when vertical panel location changed #100)
  • Fix AppBarWindow initial position when on a secondary screen with high DPI and in auto-hide or no-appbar mode
  • Fix disabled windows, which can't be restored, being allowed to minimize

dremin added 8 commits January 29, 2025 01:47
@dremin
Misc window management fixes
4784476 
- Use new shell hook messages in Win8+ for handling window monitor changes instead of event hook, as well as for full-screen app notifications
- Adapt FullScreenHelper to use new TasksService events instead of a timer on Win8+
- Stop handling HSHELL_GETMINRECT as it was broken. Made some updates to this code to be more correct, but without success.
- Added some properties to ApplicationWindow to simplify other code
- Simplified code to bring a window to the front by using SwitchToThisWindow, which handles the special cases we used to handle
- Improve FullScreenHelper logic and logging
- Fix ResetScreenCache on newer .NET versions (#100)
@dremin
Shells can now provide a minimize rect
168fffe 
Fixed NativeWindowEx message object passing so that the result value is actually used
Added event to ApplicationWindow that shells can handle to provide a button rect when requested
@dremin
Use MonitorChanged event for FullScreenHelper
f1349f1
@dremin
Revert using SwitchToThisWindow
7c58d73
@dremin
Fix auto-hide bar position on scaled secondary screen
fdccbfc
@dremin
Fix comment typo
e07aea4
@dremin
Add pinvoke for IsWindowEnabled
6232369
@dremin
Don't minimize disabled windows which can't restore
dab9a99
@dremin dremin requested a review from josuave January 31, 2025 06:13
@josuave josuave merged commit 7306747 into master Jan 31, 2025
1 check passed
@dremin dremin mentioned this pull request Jan 31, 2025
Closed
@josuave josuave deleted the misc-window-fixes branch February 2, 2025 15:40
@dremin dremin mentioned this pull request Feb 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josuave josuave Awaiting requested review from josuave

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dremin @josuave