Skip to content

feat: add emoji picker to About editor#28238

Closed
deepshekhardas wants to merge 1 commit intocalcom:mainfrom
deepshekhardas:feat/about-emoji-picker
Closed

feat: add emoji picker to About editor#28238
deepshekhardas wants to merge 1 commit intocalcom:mainfrom
deepshekhardas:feat/about-emoji-picker

Conversation

@deepshekhardas
Copy link

What does this PR do?

Adds an emoji picker to the rich-text editor used in the 'About' section of the user profile.

The Problem

Users previously had to copy-paste or use system shortcuts to add emojis to their profile bio, which was inconsistent and lacked parity with other rich-text features.

The Solution

  • Integrated emoji-picker-react into the ToolbarPlugin.
  • Added an emoji button (sparkles icon) that opens a Popover.
  • Emojis are inserted at the current cursor position as plain Unicode text.
  • No backend or schema changes required.

Fixes #27935

@deepshekhardas deepshekhardas requested review from a team as code owners March 2, 2026 08:41
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Mar 2, 2026
@github-actions github-actions bot added ✨ feature New feature or request 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand labels Mar 2, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/ui/components/editor/plugins/ToolbarPlugin.tsx">

<violation number="1" location="packages/ui/components/editor/plugins/ToolbarPlugin.tsx:551">
P2: Emoji picker is not conditionally rendered unlike other toolbar items. Should wrap the Popover in `{!props.excludedToolbarItems?.includes("emoji") && (...)}` to match the existing pattern for toolbar item exclusions.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

{isLink && createPortal(<FloatingLinkEditor editor={editor} />, document.body)}{" "}
</>
)}
<Popover>
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Emoji picker is not conditionally rendered unlike other toolbar items. Should wrap the Popover in {!props.excludedToolbarItems?.includes("emoji") && (...)} to match the existing pattern for toolbar item exclusions.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/ui/components/editor/plugins/ToolbarPlugin.tsx, line 551:

<comment>Emoji picker is not conditionally rendered unlike other toolbar items. Should wrap the Popover in `{!props.excludedToolbarItems?.includes("emoji") && (...)}` to match the existing pattern for toolbar item exclusions.</comment>

<file context>
@@ -537,6 +548,26 @@ export default function ToolbarPlugin(props: TextEditorProps) {
               {isLink && createPortal(<FloatingLinkEditor editor={editor} />, document.body)}{" "}
             </>
           )}
+          <Popover>
+            <PopoverTrigger asChild>
+              <Button
</file context>
Fix with Cubic

@romitg2
Copy link
Member

romitg2 commented Mar 2, 2026

@deepshekhardas issue needs approval, will reopen if team approves the issue.

@romitg2 romitg2 closed this Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Created by Linear-GitHub Sync ✨ feature New feature or request 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add emoji picker to About editor for improved personalization

2 participants