feat: add emoji picker to About editor#28238
Closed
deepshekhardas wants to merge 1 commit intocalcom:mainfrom
Closed
feat: add emoji picker to About editor#28238deepshekhardas wants to merge 1 commit intocalcom:mainfrom
deepshekhardas wants to merge 1 commit intocalcom:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/ui/components/editor/plugins/ToolbarPlugin.tsx">
<violation number="1" location="packages/ui/components/editor/plugins/ToolbarPlugin.tsx:551">
P2: Emoji picker is not conditionally rendered unlike other toolbar items. Should wrap the Popover in `{!props.excludedToolbarItems?.includes("emoji") && (...)}` to match the existing pattern for toolbar item exclusions.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| {isLink && createPortal(<FloatingLinkEditor editor={editor} />, document.body)}{" "} | ||
| </> | ||
| )} | ||
| <Popover> |
Contributor
There was a problem hiding this comment.
P2: Emoji picker is not conditionally rendered unlike other toolbar items. Should wrap the Popover in {!props.excludedToolbarItems?.includes("emoji") && (...)} to match the existing pattern for toolbar item exclusions.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/ui/components/editor/plugins/ToolbarPlugin.tsx, line 551:
<comment>Emoji picker is not conditionally rendered unlike other toolbar items. Should wrap the Popover in `{!props.excludedToolbarItems?.includes("emoji") && (...)}` to match the existing pattern for toolbar item exclusions.</comment>
<file context>
@@ -537,6 +548,26 @@ export default function ToolbarPlugin(props: TextEditorProps) {
{isLink && createPortal(<FloatingLinkEditor editor={editor} />, document.body)}{" "}
</>
)}
+ <Popover>
+ <PopoverTrigger asChild>
+ <Button
</file context>
Member
|
@deepshekhardas issue needs approval, will reopen if team approves the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an emoji picker to the rich-text editor used in the 'About' section of the user profile.
The Problem
Users previously had to copy-paste or use system shortcuts to add emojis to their profile bio, which was inconsistent and lacked parity with other rich-text features.
The Solution
Fixes #27935