Skip to content

feat: add emoji picker to About editor #28238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deepshekhardas wants to merge 1 commit into from
Closed

feat: add emoji picker to About editor #28238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions packages/ui/components/editor/plugins/ToolbarPlugin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ import { Button } from "../../button";
import { Dropdown, DropdownMenuContent, DropdownMenuItem, DropdownMenuTrigger } from "../../dropdown";
import { Icon } from "../../icon";
import type { TextEditorProps } from "../types";
import { Popover, PopoverContent, PopoverTrigger } from "../../popover";
import EmojiPicker, { EmojiStyle } from "emoji-picker-react";
import { AddVariablesDropdown } from "./AddVariablesDropdown";

const LowPriority = 1;
Expand Down Expand Up @@ -453,6 +455,15 @@ export default function ToolbarPlugin(props: TextEditorProps) {
[editor, isLink]
);

const onEmojiClick = (emojiData: { emoji: string }) => {
editor.update(() => {
const selection = $getSelection();
if ($isRangeSelection(selection)) {
selection.insertText(emojiData.emoji);
}
});
};

if (!props.editable) return null;
return (
<div className="toolbar flex gap-1" ref={toolbarRef}>
Expand Down Expand Up @@ -537,6 +548,26 @@ export default function ToolbarPlugin(props: TextEditorProps) {
{isLink && createPortal(<FloatingLinkEditor editor={editor} />, document.body)}{" "}
</>
)}
<Popover>
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Mar 2, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Emoji picker is not conditionally rendered unlike other toolbar items. Should wrap the Popover in {!props.excludedToolbarItems?.includes("emoji") && (...)} to match the existing pattern for toolbar item exclusions.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At packages/ui/components/editor/plugins/ToolbarPlugin.tsx, line 551:

<comment>Emoji picker is not conditionally rendered unlike other toolbar items. Should wrap the Popover in `{!props.excludedToolbarItems?.includes("emoji") && (...)}` to match the existing pattern for toolbar item exclusions.</comment>

<file context>
@@ -537,6 +548,26 @@ export default function ToolbarPlugin(props: TextEditorProps) {
               {isLink && createPortal(<FloatingLinkEditor editor={editor} />, document.body)}{" "}
             </>
           )}
+          <Popover>
+            <PopoverTrigger asChild>
+              <Button
</file context>
Fix with Cubic

<PopoverTrigger asChild>
<Button
aria-label="Emoji"
color="minimal"
variant="icon"
type="button"
StartIcon="sparkles"
/>
</PopoverTrigger>
<PopoverContent className="w-full border-none p-0" sideOffset={10}>
<EmojiPicker
onEmojiClick={onEmojiClick}
autoFocusSearch={false}
emojiStyle={EmojiStyle.NATIVE}
width={350}
height={400}
/>
</PopoverContent>
</Popover>
</div>
{props.variables && (
<div className={`${props.addVariableButtonTop ? "-mt-10" : ""} ml-auto`}>
Expand Down
1 change: 1 addition & 0 deletions packages/ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@
"cmk": "0.1.1",
"date-fns": "3.6.0",
"downshift": "6.1.9",
"emoji-picker-react": "^4.0.0",
"lexical": "0.9.0",
"react-colorful": "5.6.1",
"react-day-picker": "8.10.1",
Expand Down
19 changes: 19 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3227,6 +3227,7 @@ __metadata:
cmk: "npm:0.1.1"
date-fns: "npm:3.6.0"
downshift: "npm:6.1.9"
emoji-picker-react: "npm:^4.0.0"
execa: "npm:9.3.0"
fast-glob: "npm:3.3.2"
fs-extra: "npm:11.3.2"
Expand Down Expand Up @@ -21428,6 +21429,17 @@ __metadata:
languageName: node
linkType: hard

"emoji-picker-react@npm:^4.0.0":
version: 4.18.0
resolution: "emoji-picker-react@npm:4.18.0"
dependencies:
flairup: "npm:1.0.0"
peerDependencies:
react: ">=16"
checksum: 10/a42192f5ee5310e44f759b79e567ceace63ae83d7b339ce18d562bedff5d0c91b229bf221ea7d64a7cd90608916cb5128fe03f032d1d155d6730443da1c0cd46
languageName: node
linkType: hard

"emoji-regex@npm:^10.2.1, emoji-regex@npm:^10.3.0":
version: 10.5.0
resolution: "emoji-regex@npm:10.5.0"
Expand Down Expand Up @@ -23029,6 +23041,13 @@ __metadata:
languageName: node
linkType: hard

"flairup@npm:1.0.0":
version: 1.0.0
resolution: "flairup@npm:1.0.0"
checksum: 10/9125711da6effe146fa748fda4c293027a142bde7cc9264d6e515a5845c79181d6fdb63bb1254a5c364006b333a1083d06ac6ead0c2e3c28024c977363e19571
languageName: node
linkType: hard

"flat@npm:6.0.1":
version: 6.0.1
resolution: "flat@npm:6.0.1"
Expand Down
Loading