Skip to content

Fix styles order #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2025
Merged

Fix styles order #702

merged 2 commits into from
May 16, 2025

Conversation

stefanlogue
Copy link
Contributor

Summary:

When applying styles to the Slider, some styles are overwritten by the defaultStyles. This can lead to behaviour which the user does not expect. Closes #680

Test Plan:

  1. Run the example app with no changes
  2. Observe the slider components
  3. Add a style prop with height: 40 to any of the examples
  4. Observe the height property is applied correctly to the slider

BartoszKlonowski
BartoszKlonowski approved these changes May 16, 2025
View reviewed changes
Copy link
Member

@BartoszKlonowski BartoszKlonowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply and effective, thanks so much!

@BartoszKlonowski BartoszKlonowski merged commit 845d7ba into callstack:main May 16, 2025
9 checks passed
BartoszKlonowski pushed a commit that referenced this pull request May 16, 2025
@stefanlogue @BartoszKlonowski
Fix styles order (#702)
4d6c909 
* fix(Slider): change order styles are applied

* test(Slider): update snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BartoszKlonowski BartoszKlonowski BartoszKlonowski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Height on style object not working

2 participants

@stefanlogue @BartoszKlonowski