Skip to content

Fix styles order #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025
Merged

Fix styles order #702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7e6da1
fix(Slider): change order styles are applied
stefanlogue Apr 28, 2025
9e64ba2
test(Slider): update snapshots
stefanlogue Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package/src/Slider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ const SliderComponent = (
const defaultStyle =
Platform.OS === 'ios' ? styles.defaultSlideriOS : styles.defaultSlider;
const sliderStyle = {zIndex: 1, width: width};
const style = [props.style, defaultStyle];
const style = [defaultStyle, props.style];

const onValueChangeEvent = (event: Event) => {
onValueChange && onValueChange(event.nativeEvent.value);
Expand Down
14 changes: 7 additions & 7 deletions package/src/__tests__/__snapshots__/Slider.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ exports[`<Slider /> accessibilityState disabled sets disabled={true} 1`] = `
style={
[
[
undefined,
{
"height": 40,
},
undefined,
],
{
"justifyContent": "center",
Expand Down Expand Up @@ -63,10 +63,10 @@ exports[`<Slider /> disabled prop overrides accessibilityState.disabled 1`] = `
style={
[
[
undefined,
{
"height": 40,
},
undefined,
],
{
"justifyContent": "center",
Expand Down Expand Up @@ -120,10 +120,10 @@ exports[`<Slider /> disabled prop overrides accessibilityState.enabled 1`] = `
style={
[
[
undefined,
{
"height": 40,
},
undefined,
],
{
"justifyContent": "center",
Expand Down Expand Up @@ -177,10 +177,10 @@ exports[`<Slider /> renders a slider with custom props 1`] = `
style={
[
[
undefined,
{
"height": 40,
},
undefined,
],
{
"justifyContent": "center",
Expand Down Expand Up @@ -233,10 +233,10 @@ exports[`<Slider /> renders a slider with custom stepMaker 1`] = `
style={
[
[
undefined,
{
"height": 40,
},
undefined,
],
{
"justifyContent": "center",
Expand Down Expand Up @@ -32337,10 +32337,10 @@ exports[`<Slider /> renders disabled slider 1`] = `
style={
[
[
undefined,
{
"height": 40,
},
undefined,
],
{
"justifyContent": "center",
Expand Down Expand Up @@ -32394,10 +32394,10 @@ exports[`<Slider /> renders enabled slider 1`] = `
style={
[
[
undefined,
{
"height": 40,
},
undefined,
],
{
"justifyContent": "center",
Expand Down
Loading