Skip to content

fix: Remove persistent error guard to enable automatic certificate request retry #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Remove persistent error guard to enable automatic certificate request retry #202

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85acc46
Initial plan
Copilot Feb 16, 2026
b7ca8ff
Remove persistent error guard to enable automatic retry of failed cer…
Copilot Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 3 additions & 23 deletions src/charm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,15 +196,12 @@ def _configure_acme_ca_certificates_bundle(self):
def _configure_certificates(self):
"""Attempt to fulfill all certificate requests.

This method implements retry logic that distinguishes between transient and persistent errors:
- Transient errors (SERVER_NOT_AVAILABLE): Network issues, connection failures
These requests will be retried on the next hook
- Persistent errors (DOMAIN_NOT_ALLOWED, IP_NOT_ALLOWED, OTHER): All other errors
These requests will NOT be retried
Automatically retries all outstanding certificate requests, including those that
previously failed. If the underlying issue has been resolved, the request will
succeed and the error will be replaced with a certificate.
"""
certificate_requests = self._tls_certificates.get_certificate_requests()
provided_certificates = self._tls_certificates.get_provider_certificates()
provider_errors = self._tls_certificates.get_provider_certificate_errors()

certificate_pair_map = {
csr: list(
Expand All @@ -220,27 +217,10 @@ def _configure_certificates(self):
for csr in certificate_requests
}

persistent_error_requests = {
(error.relation_id, error.certificate_signing_request.raw)
for error in provider_errors
if error.error.code != CertificateRequestErrorCode.SERVER_NOT_AVAILABLE.value
}

for certificate_request, assigned_certificates in certificate_pair_map.items():
if assigned_certificates:
continue

request_key = (
certificate_request.relation_id,
certificate_request.certificate_signing_request.raw,
)
if request_key in persistent_error_requests:
logger.debug(
"Skipping certificate request with persistent error: %s",
certificate_request.certificate_signing_request.raw,
)
continue

with self.maintenance_status(
f"processing certificate request for relation {certificate_request.certificate_signing_request.common_name}"
):
Expand Down
Loading