Skip to content

Add optional flags to provides endpoints #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rpbritton
Copy link

@rpbritton rpbritton commented Jun 26, 2025

Issue

Since provides endpoints can be non-optional, can the default value of optional is false, these endpoints are assumed non-optional.

Solution

Set optional flag on provides endpoints to indicate correct optionality.

Checklist

  • I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.15%. Comparing base (be08648) to head (fbb80b9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1018   +/-   ##
=======================================
  Coverage   73.15%   73.15%           
=======================================
  Files          15       15           
  Lines        3866     3866           
  Branches      566      566           
=======================================
  Hits         2828     2828           
  Misses        827      827           
  Partials      211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dragomirp dragomirp requested review from a team, taurus-forever, dragomirp and marceloneppel and removed request for a team June 27, 2025 09:54
Comment on lines +54 to +57
optional: true
grafana-dashboard:
interface: grafana_dashboard
optional: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should make those endpoints optional because it would be important to warn the users to properly set up the monitoring of the database to avoid different issues not being correctly caught.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants