Skip to content

Add optional flags to provides endpoints #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add optional flags to provides endpoints #1018

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
beaab33
Add optional flags to provides endpoints
rpbritton Jun 26, 2025
fbb80b9
Remove optional flag from provided db endpoints
rpbritton Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,10 @@ provides:
interface: pgsql
metrics-endpoint:
interface: prometheus_scrape
optional: true
grafana-dashboard:
interface: grafana_dashboard
optional: true
Comment on lines +54 to +57
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should make those endpoints optional because it would be important to warn the users to properly set up the monitoring of the database to avoid different issues not being correctly caught.


requires:
replication:
Expand Down
Loading