fix(ubuntu_localizations): use fallback if locale is 'POSIX' or 'und'#476
Merged
d-loose merged 3 commits intocanonical:mainfrom Apr 11, 2025
Merged
fix(ubuntu_localizations): use fallback if locale is 'POSIX' or 'und'#476d-loose merged 3 commits intocanonical:mainfrom
d-loose merged 3 commits intocanonical:mainfrom
Conversation
ashuntu
requested changes
Apr 10, 2025
Co-authored-by: ashuntu <ashton.nelson@canonical.com>
jpnurmi
reviewed
Apr 11, 2025
Contributor
jpnurmi
left a comment
jpnurmi
left a comment
There was a problem hiding this comment.
Doing the fixup in findSystemLocale().then() would avoid unnecessarily calling findSystemLocale() when a specific locale is selected in the installer. 😉
Member
Author
|
Thanks :) |
ashuntu
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
Intl.defaultLocaleis initialized withund(undefined) orPOSIXlocalizing aDateTimewithDateFormat(and possibly other things) will throw an exception. See ubuntu/app-center#1659 for more details.A simple workaround has been suggested here.