Skip to content

fix(ubuntu_localizations): use fallback if locale is 'POSIX' or 'und' #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d-loose merged 3 commits into from
Apr 11, 2025
Merged

fix(ubuntu_localizations): use fallback if locale is 'POSIX' or 'und' #476

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df9c130
fix(ubuntu_localizations): use fallback if locale is 'POSIX' or 'und'
d-loose Apr 10, 2025
de34b08
fix: use previously defined `systemLocale`
d-loose Apr 11, 2025
ad900d1
fix: avoid calling `findSystemLocale()` if not necessary
d-loose Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/ubuntu_localizations/lib/src/localizations.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@
/// * [Intl.defaultLocale]
/// * [Intl.systemLocale]
Future<void> initDefaultLocale([String? locale]) async {
Intl.defaultLocale = locale ?? await findSystemLocale();
Intl.defaultLocale = locale ??
await findSystemLocale()

Check warning on line 34 in packages/ubuntu_localizations/lib/src/localizations.dart

View check run for this annotation

Codecov / codecov/patch

packages/ubuntu_localizations/lib/src/localizations.dart#L33-L34 

Added lines #L33 - L34 were not covered by tests
// Fallback to 'en' if the system locale is 'POSIX' or undefined.
.then((l) => l == 'POSIX' || l == 'und' ? 'en' : l);

Check warning on line 36 in packages/ubuntu_localizations/lib/src/localizations.dart

View check run for this annotation

Codecov / codecov/patch

packages/ubuntu_localizations/lib/src/localizations.dart#L36 

Added line #L36 was not covered by tests
}

/// A localized language and its locale.
Expand Down