Skip to content

High bitrate/samplerate is now correctly clipped #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
captbaritone merged 7 commits into from
Nov 28, 2025
Merged

High bitrate/samplerate is now correctly clipped #1318

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
aef33c1
High bitrate/samplerate is now correctly clipped
0x5066 Oct 28, 2025
c19d3ef
Moved globals to be local to their designated functions
0x5066 Oct 29, 2025
e3260b2
Use padStart and slice to more properly format the data
0x5066 Nov 4, 2025
26be9e5
Display "0" while gathering bitrate and khz
0x5066 Nov 7, 2025
de83c99
Remove logging of kbps in console
0x5066 Nov 11, 2025
1602642
Assign ``finalKhz`` properly
0x5066 Nov 11, 2025
60e4b00
Make CI hopefully happy
0x5066 Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions packages/webamp/js/reducers/tracks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,27 @@ export interface TracksState {
[id: string]: PlaylistTrack;
}

function massageKhz(khz: number) {
let finalKhz: String = ' 0';
let khzNum: number = Math.round(khz / 1000);
if (khzNum != null) finalKhz = String(khzNum);
if (khzNum <= 100) finalKhz = String(khzNum);
if (khzNum <= 10) finalKhz = ' '+String(khzNum).substring(0,1);
if (khzNum >= 100) finalKhz = String(khzNum).substring(1,3);
return finalKhz;
}

function massageKbps(kbps: number) {
let finalKbps: String = ' 0';
let bitrateNum = String(Math.round(kbps / 1000));
if (bitrateNum != null) finalKbps = String(bitrateNum);
if (bitrateNum <= 100) finalKbps = ' '+String(bitrateNum);
if (bitrateNum <= 10) finalKbps = ' '+String(bitrateNum);
if (bitrateNum >= 1000) finalKbps = String(bitrateNum).substring(0,2)+'H'; // if you asked me what this meant
if (bitrateNum >= 10000) finalKbps = ' '+String(bitrateNum).substring(0,1)+'C'; // i wouldnt know what to tell you
return finalKbps;
}

const defaultPlaylistState: TracksState = {};

const tracks = (
Expand Down Expand Up @@ -80,8 +101,8 @@ const tracks = (
artist,
album,
albumArtUrl,
kbps: bitrate != null ? String(Math.round(bitrate / 1000)) : kbps,
khz: sampleRate != null ? String(Math.round(sampleRate / 1000)) : khz,
kbps: bitrate != null ? massageKbps(bitrate) : kbps,
khz: sampleRate != null ? massageKhz(sampleRate) : khz,
channels: numberOfChannels != null ? numberOfChannels : channels,
},
};
Expand Down
Loading