High bitrate/samplerate is now correctly clipped #1318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the ``kbps`` and ``kHz`` displays in the main window correctly emulate what Winamp does with high bitrates/samplerates.
✅ Deploy Preview for tourmaline-kringle-c98715 canceled.
|
captbaritone
requested changes
Oct 29, 2025
Division is no longer performed in each if condition Default to displaying "0" for the kbps and khz fields (doesn't seem to trigger, though)
captbaritone
requested changes
Oct 30, 2025
Added comment by Justin Frankel on the meaning of H and C
0x5066
commented
Nov 4, 2025
| if (bitrateNum <= 10) finalKbps = String(bitrateNum).padStart(3, " "); | ||
| // from Justin Frankel directly: | ||
| // IIRC H was for "hundred" and "C" was thousand, | ||
| // though why it was for thousand I have no idea lol, maybe it was a mistake... |
Co-authored-by: Jordan Eldredge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
kbpsandkHzdisplays in the main window correctly emulate what Winamp does with high bitrates/samplerates.Based on research and observation of Winamp, as well as code from the DeClassified skin, which emulates this behavior correctly.