Skip to content
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions packages/webamp/js/reducers/tracks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,23 +7,29 @@
}

function massageKhz(khz: number) {
let finalKhz: String = ' 0';
let finalKhz: String = " 0";
let khzNum: number = Math.round(khz / 1000);

Check failure on line 11 in packages/webamp/js/reducers/tracks.ts

View workflow job for this annotation

GitHub Actions / ci

'khzNum' is never reassigned. Use 'const' instead
if (khzNum != null) finalKhz = String(khzNum);

if (khzNum <= 100) finalKhz = String(khzNum);
if (khzNum <= 10) finalKhz = ' '+String(khzNum).substring(0,1);
if (khzNum >= 100) finalKhz = String(khzNum).substring(1,3);
if (khzNum <= 10) finalKhz = String(khzNum).slice(0, 1).padStart(2, " ");
if (khzNum >= 100) finalKhz = String(khzNum).slice(1, 3);
return finalKhz;
}

function massageKbps(kbps: number) {
let finalKbps: String = ' 0';
let bitrateNum = String(Math.round(kbps / 1000));
if (bitrateNum != null) finalKbps = String(bitrateNum);
if (bitrateNum <= 100) finalKbps = ' '+String(bitrateNum);
if (bitrateNum <= 10) finalKbps = ' '+String(bitrateNum);
if (bitrateNum >= 1000) finalKbps = String(bitrateNum).substring(0,2)+'H'; // if you asked me what this meant
if (bitrateNum >= 10000) finalKbps = ' '+String(bitrateNum).substring(0,1)+'C'; // i wouldnt know what to tell you
let finalKbps: String = " 0";
let bitrateNum: number = Math.round(kbps / 1000);

Check failure on line 21 in packages/webamp/js/reducers/tracks.ts

View workflow job for this annotation

GitHub Actions / ci

'bitrateNum' is never reassigned. Use 'const' instead

finalKbps = String(bitrateNum); // present as is
if (bitrateNum <= 100) finalKbps = String(bitrateNum).padStart(3, " ");
if (bitrateNum <= 10) finalKbps = String(bitrateNum).padStart(3, " ");
// from Justin Frankel directly:
// IIRC H was for "hundred" and "C" was thousand,
// though why it was for thousand I have no idea lol, maybe it was a mistake...
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic comment

if (bitrateNum >= 1000) finalKbps = String(bitrateNum).slice(0, 2) + "H";

Check warning on line 29 in packages/webamp/js/reducers/tracks.ts

View workflow job for this annotation

GitHub Actions / ci

Unexpected string concatenation
if (bitrateNum >= 10000)
finalKbps = String(bitrateNum).slice(0, 1).padStart(2, " ") + "C";

Check warning on line 31 in packages/webamp/js/reducers/tracks.ts

View workflow job for this annotation

GitHub Actions / ci

Unexpected string concatenation
console.log(finalKbps);
return finalKbps;
}

Expand Down
Loading