fix: add engines to package json#1010
fix: add engines to package json#1010davidmenendez merged 2 commits intocarbon-design-system:mainfrom
Conversation
✅ Deploy Preview for ai-chat-components-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-ai-chat-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-ai-chat-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| "packages/*" | ||
| ], | ||
| "engines": { | ||
| "node": ">=22.0.0", |
There was a problem hiding this comment.
i thought it was 24?
and whatever npm goes with that. Guess we need @annawen1
There was a problem hiding this comment.
doing some more reading on the subject i found that the suggestion for version minimums is an LTS version, which in this case would be v22 (although i did have to double check and confirmed that the npm version minimum with 22 should be 10 and not 9, so I updated it).
adding engines and .nvmrc should help to lock down whatever issues are causing lock mismatches to happen though.
if we really want to try to nip it in the bud though we can refresh the lock by deleting it and regenerating it. that would give us a solid baseline moving forward to watch out for anything causing additional unwanted changes to the lock file 🤔
There was a problem hiding this comment.
hmm yeah that does make sense to me. I think we should be fine especially now that I switched our workflows to not modify the lock file which was the main reason for us adding the engines and .nvmrc file 🤞 If we are STILL having issues with the lock file, we can try bombing it like you mentioned
There was a problem hiding this comment.
ohhh duh that should have been the first place we double checked: the workflows. good call!!
b7f11fd
3 participants
Closes #982
adds engines section to package.json
Changelog
New