Skip to content

fix: add engines to package json #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidmenendez merged 2 commits into from
Mar 2, 2026
Merged

fix: add engines to package json #1010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c58adb6
fix: add engines to package json
davidmenendez Feb 26, 2026
201dfa1
fix: set npm minimum from v9 to v10
davidmenendez Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@
"examples/*/*",
"packages/*"
],
"engines": {
"node": ">=22.0.0",
Copy link
Contributor

@ethanwinters ethanwinters Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought it was 24?

and whatever npm goes with that. Guess we need @annawen1

Copy link
Contributor Author

@davidmenendez davidmenendez Feb 27, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doing some more reading on the subject i found that the suggestion for version minimums is an LTS version, which in this case would be v22 (although i did have to double check and confirmed that the npm version minimum with 22 should be 10 and not 9, so I updated it).

adding engines and .nvmrc should help to lock down whatever issues are causing lock mismatches to happen though.

if we really want to try to nip it in the bud though we can refresh the lock by deleting it and regenerating it. that would give us a solid baseline moving forward to watch out for anything causing additional unwanted changes to the lock file 🤔

Copy link
Member

@annawen1 annawen1 Mar 2, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm yeah that does make sense to me. I think we should be fine especially now that I switched our workflows to not modify the lock file which was the main reason for us adding the engines and .nvmrc file 🤞 If we are STILL having issues with the lock file, we can try bombing it like you mentioned

Copy link
Contributor Author

@davidmenendez davidmenendez Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhh duh that should have been the first place we double checked: the workflows. good call!!

"npm": ">=10.0.0"
},
"scripts": {
"aiChat:build": "lerna run build --stream --scope @carbon/ai-chat-components --scope @carbon/ai-chat --scope @carbon/ai-chat-examples-demo",
"aiChat:build:profile": "cross-env profile=true lerna run build --stream --scope @carbon/ai-chat-components --scope @carbon/ai-chat",
Expand Down