fix: workspace toolbar and header responsiveness#955
fix: workspace toolbar and header responsiveness#955davidmenendez merged 7 commits intocarbon-design-system:mainfrom
Conversation
✅ Deploy Preview for carbon-ai-chat-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ai-chat-components-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-ai-chat-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| "react": ">=17.0.0 <20.0.0" | ||
| }, | ||
| "dependencies": { | ||
| "@carbon/ibm-products-web-components": "^0.32.0", |
There was a problem hiding this comment.
Hmm I think we were a bit hesitant to add the ibm products package, but it's looking like we'll need to utilize more and more components and utilities from there
There was a problem hiding this comment.
yeah i get that. i was hoping in thie PR i'd also be able to utilize options-tile. i had forgotten that the overflow handler that was originally built in c4p was added to core utilities, so that was already being used. if it's not a dependency we want to add i'm sure i can port over the truncated-text functionality and then maybe work to getting that util put in core. seems like a pretty standard utility, so i'm sure it could have wider impact there than in products 🤔
There was a problem hiding this comment.
yeah lets port it over rather than bringing in all of ibm products.
Could also consider if its a util the belongs in core?
Oh... you said that too lol
I'm down with porting for now and then making an issue to add to core later to make it speedier.
|
@ethanwinters @annawen1 ported over the |
|
Noticed this minor horizontal scrollbar appearing on the React float version And in Web Components, this is happening 😬 |
|
@annawen1 just FYI whatever change happened to add all that additional scrolling, which i'm guessing is new because i'd like to think i'd have noticed that haha, is in main. i can definitely take a look at it though |
|
@annawen1 @ethanwinters merged the latest main in with the scrolling body fix and added final touches to adjust spacing in the header detail dropdown area to align with the original implementation. 
|
I'm still seeing the horizontal scrollbar appear on float mode, but it's a minor bug so I'll go ahead and approve so I'm not blocking the other issues. |
8cac067
3 participants
Closes #890
makes some changes to the workspace for better responsive handling
Changelog
New
c4p-truncated-textcomponent into the header for better title truncationworkspace-header-toggleevent in the details toggle to allow for specific structuring of header and body components in the expanded and collapsed state. refer to the figma for more detailsTesting / Reviewing
manual testing. wanted to get feedback before adding additional unit tests.