Initialize cpp_mangle_context_ in Mangler's constructor
#5095
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup of a comment in #5062.
Add a mutable AST pointer to
FileContext.This is necessary since we use Clang with lack of const correctness.
Alternatives in Clang:
ASTUnit::getASTContext() constto return a non-constASTContext. Tried and was rejected upstream due to weakening const correctness.createMangleContext()to beconst. Tried that and it seems like it relies heavily on non const API.MangleContext::mangleName()toconst. Tried that but there are several lazy initialization and id creations happening that modify the context. See details in [Clang] MakeMangleContext::mangleMSGuidDecl(),MangleContext::mangleObjCMethodName()andMangleContext::mangleObjCMethodNameAsSourceName()const methods llvm/llvm-project#130613.Alternatives in Carbon:
const_castonASTContextwhen callingcreateMangleContext().FileContext::sem_ir_point to a mutableSemIR::File.File::cpp_ast()to be const while keeping it return a mutable pointer.Part of #4666.