Address PR review comments #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use else if to make the conditional logic clearer in the inactive version scaling code. Addresses: #127 (comment)
jlegrone
commented
Aug 25, 2025
jlegrone
force-pushed
the
jlegrone/address-pr-comments
branch
from
927e096 to
a60db1f
Compare
Change TaskQueueEnvKey to taskQueueEnvKey since it's not used outside the package. Addresses: #127 (comment)
jlegrone
force-pushed
the
jlegrone/address-pr-comments
branch
from
a60db1f to
064336a
Compare
- Move field descriptions from README to proper godoc comments on TestCase struct - Create testable examples in example_test.go with compile-time checks - Update README to reference godoc and examples instead of duplicating struct definition Addresses: #127 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
else ifinstead ofelse+ nestedif