Skip to content

Request storage access in iframe connect flow#2374

Merged
tarrencev merged 1 commit intomainfrom
codex/iframe-storage-access
Feb 5, 2026
Merged

Request storage access in iframe connect flow#2374
tarrencev merged 1 commit intomainfrom
codex/iframe-storage-access

Conversation

@Larkooo
Copy link
Contributor

@Larkooo Larkooo commented Feb 5, 2026

Summary\n- Request Storage Access API in iframe connect flow before completing connect/skip\n- Allows third-party storage (cookies/localStorage) to persist across restarts in WKWebView\n\n## Testing\n- Not run (requires device/WebView testing)

@vercel
Copy link

vercel bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
controller-example-next Ready Ready Preview Feb 5, 2026 5:33pm
keychain Ready Ready Preview Feb 5, 2026 5:33pm
keychain-storybook Ready Ready Preview Feb 5, 2026 5:33pm

Request Review

@claude
Copy link
Contributor

claude bot commented Feb 5, 2026


Code review

No issues found. Checked for bugs and CLAUDE.md compliance.


@tarrencev tarrencev merged commit 9708f87 into main Feb 5, 2026
12 checks passed
@tarrencev tarrencev deleted the codex/iframe-storage-access branch February 5, 2026 17:36
@claude
Copy link
Contributor

claude bot commented Feb 5, 2026

Claude finished @Larkooo's task —— View job


Analyzing PR and updating documentation

I'll analyze the Storage Access API changes and update the documentation accordingly.

Tasks:

  • Review the changed file to understand Storage Access API implementation
  • Explore docs-repo structure and existing documentation
  • Determine if documentation updates are needed
  • Update relevant documentation files if necessary

Analysis:
The PR adds Storage Access API support to solve a specific iOS/WebView issue where third-party cookies and localStorage don't persist across app restarts. The implementation:

  1. Calls requestStorageAccess() in both Connect and Skip flows when in iframe context
  2. Only affects mobile/WebView users (not standalone web users)
  3. Improves persistence of authentication state in iOS apps using WKWebView

Documentation Status:
After reviewing the existing documentation, I found that Storage Access API handling is already well-documented in the configuration.md file. The existing documentation covers:

  • Storage Access API detection and management
  • Cross-domain iframe functionality
  • Browser compatibility notes for Safari/Chrome/Firefox
  • The controller.open() standalone flow that establishes first-party storage

The changes in this PR align perfectly with the existing documentation and don't introduce new user-facing functionality that requires documentation updates. The Storage Access API call is an implementation detail that improves reliability of existing functionality rather than adding new features.

Conclusion: No documentation updates are needed. The existing documentation already covers Storage Access API functionality and this PR simply improves the reliability of that existing behavior for iOS/WebView users.


@github-actions github-actions bot mentioned this pull request Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants