Skip to content

Request storage access in iframe connect flow #2374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarrencev merged 1 commit into from
Feb 5, 2026
Merged

Request storage access in iframe connect flow #2374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions packages/keychain/src/components/ConnectRoute.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
} from "@/hooks/route";
import { isIframe } from "@cartridge/ui/utils";
import { safeRedirect } from "@/utils/url-validator";
import { requestStorageAccess } from "@/utils/connection/storage-access";

const CANCEL_RESPONSE = {
code: ResponseCodes.CANCELED,
Expand Down Expand Up @@ -54,6 +55,16 @@ export function ConnectRoute() {
return;
}

// In iframe context, request storage access on user gesture so
// third-party storage can persist across app restarts.
if (!isStandalone) {
try {
await requestStorageAccess();
} catch (error) {
console.error("[ConnectRoute] Storage access request failed:", error);
}
}

params.resolve?.({
code: ResponseCodes.SUCCESS,
address: controller.address(),
Expand Down Expand Up @@ -100,6 +111,14 @@ export function ConnectRoute() {
return;
}

if (!isStandalone) {
try {
await requestStorageAccess();
} catch (error) {
console.error("[ConnectRoute] Storage access request failed:", error);
}
}

params.resolve?.({
code: ResponseCodes.SUCCESS,
address: controller.address(),
Expand Down
Loading