Skip to content

Add ViewDashboard action for external dashboard integration#537

Merged
mpawliszyn merged 1 commit intocashapp:masterfrom
emilydespas:emilyd.add-external-dashboard-link
Feb 2, 2026
Merged

Add ViewDashboard action for external dashboard integration#537
mpawliszyn merged 1 commit intocashapp:masterfrom
emilydespas:emilyd.add-external-dashboard-link

Conversation

@emilydespas
Copy link
Contributor

What

Adds a "View Dashboard" button to the backfill run page that redirects to external dashboard providers. Follows the same provider pattern as the existing ViewLogsAction.

Why

Enables integrators to link backfill runs to external monitoring/observability dashboards, providing a consistent way to view runtime metrics and health data alongside logs.

## What
Adds a "View Dashboard" button to the backfill run page that redirects to external dashboard providers. Follows the same provider pattern as the existing ViewLogsAction.

## Why
Enables integrators to link backfill runs to external monitoring/observability dashboards, providing a consistent way to view runtime metrics and health data alongside logs.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@emilydespas
Copy link
Contributor Author

Screenshot 2026-02-02 at 12 52 44 PM

Copy link
Contributor

@mpawliszyn mpawliszyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mpawliszyn mpawliszyn merged commit 0cbe75e into cashapp:master Feb 2, 2026
3 checks passed
@emilydespas emilydespas deleted the emilyd.add-external-dashboard-link branch February 2, 2026 21:53
jeffhwang-sq added a commit that referenced this pull request Feb 11, 2026
…hboardUrlProvider

PR #537 introduced ViewDashboardAction and ViewLogsAction which require
ViewDashboardUrlProvider and ViewLogsUrlProvider to be bound in the Guice
injector. However, these bindings were not provided in BackfilaServiceModule,
causing injection failures in downstream services like cash-server.

This change adds default no-op implementations that return '#' as placeholder
URLs. These satisfy Guice's dependency requirements and allow the service to
start successfully. Deployments can override these bindings with real
implementations that link to their actual logging and monitoring infrastructure.

Fixes cash-server InjectorTest failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants