Add CASPER_NODE_ADDRESS env var.#174
Open
mpapierski wants to merge 2 commits intocasper-ecosystem:devfrom
Open
Add CASPER_NODE_ADDRESS env var.#174mpapierski wants to merge 2 commits intocasper-ecosystem:devfrom
CASPER_NODE_ADDRESS env var.#174mpapierski wants to merge 2 commits intocasper-ecosystem:devfrom
Conversation
This makes it easier to use multiple commands without remembering to set `--node-address`. With this change casper-client will try to load its value from env variable `CASPER_NODE_ADDRESS`.
gRoussac
reviewed
Jun 18, 2024
| const ARG_VALUE_NAME: &str = "HOST:PORT"; | ||
| const ARG_DEFAULT: &str = "http://localhost:7777"; | ||
| const ARG_HELP: &str = "Hostname or IP and port of node on which HTTP service is running"; | ||
| const ARG_ENV: &str = "CASPER_NODE_ADDRESS"; |
Contributor
There was a problem hiding this comment.
Hi,
Can we try to avoid CASPER_ prefixes ? Is it still a node or an rpc RPC_ADDRESS ?
It would be great to unify that with CI/CD like
NODE_ADDRESS=http://localhost:7777 (or RPC_ADDRESS)
EVENT_ADDRESS=http://localhost:9999/events/main
SPECULATIVE_ADDRESS=http://localhost:7778
Contributor
There was a problem hiding this comment.
to me the client should now use RPC_ADDRESS and the binary client NODE_ADDRESS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier to use multiple commands without remembering to set
--node-address. With this change, casper-client will try to load its value from env variableCASPER_NODE_ADDRESS.