Skip to content

Add CASPER_NODE_ADDRESS env var. #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mpapierski wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Add CASPER_NODE_ADDRESS env var. #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f82203a
Add `CASPER_NODE_ADDRESS` env var.
mpapierski Jun 18, 2024
48c1588
Add a const
mpapierski Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ async-trait = { version = "0.1.74", optional = true }
base16 = "0.2.1"
casper-hashing = "3.0.0"
casper-types = { version = "4.0.1", features = ["std"] }
clap = { version = "~4.4", optional = true, features = ["cargo", "deprecated", "wrap_help"] }
clap = { version = "~4.4", optional = true, features = ["cargo", "deprecated", "wrap_help", "env"] }
clap_complete = { version = "<4.5.0", optional = true }
hex-buffer-serde = "0.4.0"
humantime = "2.1.0"
Expand Down
2 changes: 2 additions & 0 deletions src/common.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,13 @@ pub mod node_address {
const ARG_VALUE_NAME: &str = "HOST:PORT";
const ARG_DEFAULT: &str = "http://localhost:7777";
const ARG_HELP: &str = "Hostname or IP and port of node on which HTTP service is running";
const ARG_ENV: &str = "CASPER_NODE_ADDRESS";
Copy link
Contributor

@gRoussac gRoussac Jun 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Can we try to avoid CASPER_ prefixes ? Is it still a node or an rpc RPC_ADDRESS ?

It would be great to unify that with CI/CD like

NODE_ADDRESS=http://localhost:7777 (or RPC_ADDRESS)
EVENT_ADDRESS=http://localhost:9999/events/main
SPECULATIVE_ADDRESS=http://localhost:7778

Copy link
Contributor

@gRoussac gRoussac Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to me the client should now use RPC_ADDRESS and the binary client NODE_ADDRESS


pub fn arg(order: usize) -> Arg {
Arg::new(ARG_NAME)
.long(ARG_NAME)
.short(ARG_SHORT)
.env(ARG_ENV)
.required(false)
.default_value(ARG_DEFAULT)
.value_name(ARG_VALUE_NAME)
Expand Down