feat(balance): nerf senior citizen profession with elderly traits

[DeinonychusDiscord]

Purpose of change (The Why)

Senior Citizen was a completely pointless profession. It was basically just a reskinned survivor with slightly fancy casual clothes and a tobacco pipe.

Describe the solution (The How)

Made the senior citizen, which is clearly intended to be a parody role of the porch-shouting rocking chair elderly american, more fleshed out.

They have the typical signs of old age in retirement now - bad back, bad knees, bad cardio, far-sighted [since stereotypical old people are portrayed needing reading glasses], and slow running.

Describe alternatives you've considered

I also considered making them clumsy to represent just generally not moving very well anymore due to joint calcification, old injuries that never healed properly, or just "bad" joints, but felt that might go from satirical to outright cartoonish.

The thought did cross my mind of making them also have psychosis to represent "since the war", with the random hallucinations standing in for "flashbacks from the war" but that felt a little silly.

Testing

Tried new character screen. All traits displaying as intended.

Additional context

I'm well aware this is supposed to just be a joke profession. I thought the joke worked better when it's complete in this way.

Checklist

Mandatory

• I wrote the PR title in conventional commit format.
• I ran the code formatter.
• I linked any relevant issues using github keyword syntax like closes #1234 in Summary of the PR so it can be closed automatically.
• I've committed my changes to new branch that isn't main so it won't cause conflict when updating main branch later.

[autofix-ci]

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix

1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
2. Continue working.

I do not want the automated commit

1. Format your code locally, then commit it.
2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

[scarf005]

Suggested change

	"points": 0,
	"points": -8,

added bad traits have total -14 points, needs more bonus points.

BADKNEES: -2
BADBACK: -3
BADHEARING: -1
BADCARDIO: -4
SLOWRUNNER: -3
HYPEROPIC: -1

[DeinonychusDiscord]

Senior Citizen start is akin to Abandoned hospital patient start - they're both supposed to be challenges you take, expecting and knowing they are going to suck in some way, but doing them anyway just to prove how skillful you are as a cata player.

Abandoned scenario starts you off at 8 points gained assuming you start with default survivor profession. The default trait assigned, Frail, earns you an additional 10 points.

That's a scenario that starts you with -18 points with no effort on your part. It does not have any "bonus points" assigned. It is in the mainline vanilla game, unchanged and uncontested.

-14 is less than the -18 of an already existing scenario .

Senior Citizen starts with a walking cane - it was at least implied you're supposed to be mobility-challenged due to advanced age and its rigors on calcified joints.

I added reasonable negative traits that make sense for the profession - bad knees, bad back, out of shape, slow running, far sight. It is now the challenge it was likely always intended to be.

I could've gone with myopic, or no vision impairment entirely - and still would've given the player less points than the abandoned scenario and its one default trait.

I will reiterate once again - a person chooses to be a senior citizen because they are doing a challenge run.

If they wanted a no frills profession with no point impact at all, they'd just pick the default survivor who starts with a cutting tool and a smartphone - actual survival gear.

My changes make the senior citizen have a reason to exist - because currently it is just bloat as a profession.