Conversation
jdangerx
commented
Feb 24, 2026
zaneselvans
requested changes
Feb 24, 2026
Member
zaneselvans
left a comment
There was a problem hiding this comment.
I ran into errors when attempting to execute both the Jupyter and Marimo notebooks locally because of dependency stuff. See below.
6 tasks
This was referenced Feb 24, 2026
0ccccd6 to
116ee8c
Compare
Member
Author
|
@krivard You may want to know about this, specifically the integration testing setup, for #23 - I don't think you'll want to do super comprehensive testing of your dashboard, because that sounds both (a) hard and (b) flaky, but some basic ones to verify that things aren't crashing out is probably worthwhile. |
krivard
approved these changes
Mar 2, 2026
Contributor
krivard
left a comment
There was a problem hiding this comment.
Minor optional clarity notes but this looks good!
Comment on lines
+2
to
+4
| # NOTE 2026-02-27: these need to be imported so that Pandas can read Parquet | ||
| # files in pyodide, but are not explicitly used in the code. | ||
| allowed-unused-imports = ["fastparquet", "pyarrow"] |
11a47df to
4afe00e
Compare
* add playwright to wasm env * add pytest fixture which spins up a test server * futz around with playwright selectors to interact with different UI elements & look at charts * update GHA + export script to accommodate testing changes * update README :) * fix plant-explorer which didn't have a parquet engine imported -_-
4afe00e to
7c505b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Part of #19 , in conjunction with catalyst-cooperative/eel-hole#116
We need to build & store the webassembly versions of marimo notebooks somewhere, so that we can then grab them in eel-hole (see catalyst-cooperative/eel-hole#116).
What did you change in this PR?
.pyfiles undermarimo/to wasm notebooks in/docs- and then deploy to GH pagesNecessary chores to make this work:
uv(we could also usepixibut so far seems unnecessary? easy enough to swap though)Testing
python3 -m http.serverfrom artifact.mainbefore we can deploy to gh-pagesTo-do list
uv run pre-commit run -ato this branch so we get a nice green check mark, but don't clutter up these changes with those changes.