Fix bulk update libraries#78
Merged
Peterburnett merged 3 commits intostable-catalystfrom Dec 22, 2025
Merged
Conversation
934d427 to
3d027c7
Compare
1ee6e66 to
90e5cfa
Compare
90e5cfa to
3581398
Compare
Author
|
As a note, during some more testing I was doing, fetching the data for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes three changes:
fetchExternalDataneeds to be called first passingtruefor the$streamparam before the download path is set. We can then get the path that was used after withgetUploadedH5pPath, instead of the other way around that we had before. d4d2400update_libraries.phpfor each library that needs updating. This way any problematic libraries will not block other libraries from updating and can be retried later. 5916cb9