Add IAudioHandler #2727
Merged
Add IAudioHandler #2727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial implementation for cefsharp#2714
|
✅ Build CefSharp 73.1.120-CI3062 completed (commit 00c6dd16ee by @amaitland) |
|
✅ Build CefSharp 73.1.120-CI3072 completed (commit 9dabaaf7f1 by @amaitland) |
9 tasks
Member
Author
|
AudioMirroring is now only enabled when a handler is assigned |
amaitland
added a commit
that referenced
this pull request
May 3, 2019
* Feature Request - Add IAudioHandler - For performance reasons we return NULL if no audiohandler is assigned - No example is provided currently Initial implementation for #2714
amaitland
added a commit
that referenced
this pull request
Oct 1, 2019
The Chromium implementation has changed so dramatically that CEF has removed support see https://bitbucket.org/chromiumembedded/cef/commits/1f893c76a97eaa88e3ff782b8e2e47dd0f5d27b2 Track https://bitbucket.org/chromiumembedded/cef/issues/2755/reimplement-audio-mirroring-for for details on when it will be reimplemented Original Issue #2727
Closed
amaitland
added a commit
that referenced
this pull request
Nov 3, 2019
The Chromium implementation has changed so dramatically that CEF has removed support see https://bitbucket.org/chromiumembedded/cef/commits/1f893c76a97eaa88e3ff782b8e2e47dd0f5d27b2 Track https://bitbucket.org/chromiumembedded/cef/issues/2755/reimplement-audio-mirroring-for for details on when it will be reimplemented Original Issue #2727
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation for #2714
Still some work required, this compiles, nothing past that so far. Still need to validate how to map
float**to aC#type. One option would be to copy the data to abyte[]in native code, this implies the user is always going to want access to the data, and will have a perf implication if they don't.The default pattern of
return thisinClientAdapterhas been used.Unfortunately this will always trigger the
Audio Mirroringfeature, which we don't want unless the user has explicitly provided anIAudioHandlerimplementation. So this will also need to be rewritten with a separate wrapper class.https://bitbucket.org/chromiumembedded/cef/commits/9f41a27e586a6b557fc171d2f03b332c1338e8d2?at=3683#Llibcef/browser/browser_host_impl.ccT3046