Skip to content

refactor(store): synchronize Store writes #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 45 commits into
base: main
Choose a base branch
from
Draft

refactor(store): synchronize Store writes #241

wants to merge 45 commits into from

Conversation

Wondertan
Copy link
Member

@Wondertan Wondertan commented Jan 13, 2025 •
edited
Loading

Previously Store had a fully async nature and a range of headers written via Append wasn't guaranteed to be immediately available for Get... operations. This PR addresses the issue and synchronize writes across Store methods, yet keeping writes non-blocking for underlying IO. That is, writes still not block on disk, but reads can access what's written immediately.

Likely is gonna be merged after #239 and is draft until then.

TODO:

  • Rebase on main
  • Cleanup closing/restart logic
  • Add concurrency test case
  • Fix flaky test

@Wondertan Wondertan self-assigned this Jan 13, 2025
@Wondertan Wondertan mentioned this pull request Jan 14, 2025
Merged
@Wondertan Wondertan mentioned this pull request Jan 28, 2025
Open
@Wondertan Wondertan mentioned this pull request Mar 25, 2025
Closed
@Wondertan Wondertan mentioned this pull request May 12, 2025
Merged
Wondertan added a commit that referenced this pull request May 13, 2025
@Wondertan
feat(store): Sync (#287)
9fce763 
Adds a Sync method which ensures all pending writes are processed. It
blocks until the operation completes or fails.
Also, the method gets used in `DeleteTo`, ensuring deletion always
operates on the latest state.

This is technically a hack for until #241 and #263 come
Wondertan added a commit that referenced this pull request May 28, 2025
@Wondertan
feat(store): Sync (#287)
1755cb3 
Adds a Sync method which ensures all pending writes are processed. It
blocks until the operation completes or fails.
Also, the method gets used in `DeleteTo`, ensuring deletion always
operates on the latest state.

This is technically a hack for until #241 and #263 come
Wondertan added a commit that referenced this pull request May 29, 2025
@Wondertan
feat(store): Sync (#287)
9a62cf4 
Adds a Sync method which ensures all pending writes are processed. It
blocks until the operation completes or fails.
Also, the method gets used in `DeleteTo`, ensuring deletion always
operates on the latest state.

This is technically a hack for until #241 and #263 come
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzdybal tzdybal Awaiting requested review from tzdybal tzdybal will be requested when the pull request is marked ready for review tzdybal is a code owner

@renaynay renaynay Awaiting requested review from renaynay renaynay will be requested when the pull request is marked ready for review renaynay is a code owner

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs will be requested when the pull request is marked ready for review vgonkivs is a code owner

@gupadhyaya gupadhyaya Awaiting requested review from gupadhyaya gupadhyaya will be requested when the pull request is marked ready for review gupadhyaya is a code owner

@walldiss walldiss Awaiting requested review from walldiss walldiss will be requested when the pull request is marked ready for review walldiss is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@Wondertan Wondertan

Labels
kind:refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wondertan @cristaloleg