Skip to content

Conversation

@sdepassio
Copy link
Contributor

@sdepassio sdepassio commented Dec 19, 2025

Description

libffi7 is set as dependency for all debian/ubuntu distributions, but for debian 12 and ubuntu, only libffi8 is available.

And little updates :

  • add a default value for REGISTRY_URL in docker images
  • update ubuntu runner version for CI
  • use lua 5.4 instead of 5.3 for debian
  • improve GHA workflows

Fixes CTOR-2125

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

  • 24.04.x
  • 24.10.x
  • 25.10.x
  • master

How this pull request can be tested ?

Try to install the Kafka stream connector.

Checklist

Community contributors & Centreon team

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (master, maintenance).

@sdepassio sdepassio added the upload-artifacts Upload generated packages as artifacts label Dec 19, 2025
@sdepassio sdepassio changed the title fix(libcurl): wrong version of libffi dependency fix(lua-cffi): wrong version of libffi dependency Dec 19, 2025
@github-actions
Copy link

github-actions bot commented Dec 19, 2025

Logo
Checkmarx One – Scan Summary & Detailsbe7828ac-a9dd-4faf-bd8f-83cebc277924

Great job! No new security vulnerabilities introduced in this pull request

@sdepassio sdepassio marked this pull request as ready for review December 29, 2025 10:44
@sdepassio sdepassio requested review from a team as code owners December 29, 2025 10:44
omercier
omercier previously approved these changes Dec 29, 2025
@sdepassio sdepassio force-pushed the CTOR-2125-sc-lua-cffi-fix-lua-cffi-dependency-version branch from 749e081 to 084d5a0 Compare December 30, 2025 10:02
@sdepassio sdepassio requested a review from omercier December 31, 2025 07:38
omercier
omercier previously approved these changes Jan 2, 2026
@@ -1,4 +1,4 @@
ARG REGISTRY_URL
ARG REGISTRY_URL=docker.io
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the initial url is this https://github.com/centreon/centreon-stream-connector-scripts/blob/d1287cb06b89d96b420d3cff47b77e4ed69f1e67/.github/workflows/docker-packaging.yml#L48C11-L48C75

to avoid reaching the http calls quota at docker official registry, we may want to keep using the internal proxy
if this is to avoid the ARG error message, use the proxy url instead of docker official url

@sdepassio sdepassio marked this pull request as draft January 13, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

upload-artifacts Upload generated packages as artifacts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants