-
Notifications
You must be signed in to change notification settings - Fork 25
fix(lua-cffi): wrong version of libffi dependency #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sdepassio
wants to merge
15
commits into
develop
Choose a base branch
from
CTOR-2125-sc-lua-cffi-fix-lua-cffi-dependency-version
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
a696b43
fix(libcurl): wrong version of libffi dependency
sdepassio d11759e
update lua version for debian/ubuntu and ubuntu runner version
sdepassio da31287
add default value for REGISTRY_URL in docker images
sdepassio 1b5bac4
adding tests for packaged Lua modules
sdepassio dc3c7a4
fix
sdepassio eebd165
adding cache key for tests and removing debian for lua-sql-mysql
sdepassio c8003a2
fix
sdepassio dfc81c4
fixing sed for name in debian
sdepassio 206ef31
Fix lua-tz tests using examples from luatz github repository
sdepassio 178b7d6
adding missing dependency
sdepassio 9c32d33
update paths to run ci
sdepassio 084d5a0
adding quotes on gha paths and adding missing paths
sdepassio cd8e7c9
Update GHA to re-package stream-connectors if workflow or nfpm templa…
sdepassio 214d205
fix artifacts names
sdepassio 8947ee2
update versions
sdepassio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| name: "test-cpan-libs" | ||
| description: "Test packaged CPAN libraries" | ||
| inputs: | ||
| package_extension: | ||
| description: "The package extension (deb or rpm)" | ||
| required: true | ||
| distrib: | ||
| description: "The distribution name" | ||
| required: true | ||
| cache_key: | ||
| description: "The cache key to restore packages" | ||
| required: true | ||
|
|
||
| runs: | ||
| using: "composite" | ||
| steps: | ||
|
|
||
| - if: ${{ inputs.package_extension == 'rpm' }} | ||
| name: Install zstd and Centreon GPG key | ||
| run: | | ||
| dnf install -y zstd | ||
| # Import Centreon GPG key | ||
| GPG_KEY_URL="https://yum-gpg.centreon.com/RPM-GPG-KEY-CES" | ||
| curl -sSL $GPG_KEY_URL -o RPM-GPG-KEY-CES | ||
| rpm --import RPM-GPG-KEY-CES | ||
| shell: bash | ||
|
|
||
| - if: ${{ inputs.package_extension == 'deb' }} | ||
| name: Install zstd and Centreon GPG key | ||
| run: | | ||
| export DEBIAN_FRONTEND=noninteractive | ||
| apt-get update | ||
| apt-get install -y zstd wget gpg | ||
| wget -O- https://apt-key.centreon.com | gpg --dearmor | tee /etc/apt/trusted.gpg.d/centreon.gpg > /dev/null 2>&1 | ||
| # Avoid apt to clean packages cache directory | ||
| rm -f /etc/apt/apt.conf.d/docker-clean | ||
| apt-get update | ||
| shell: bash | ||
|
|
||
| - name: Restore packages from cache | ||
| uses: actions/cache/restore@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0 | ||
| with: | ||
| path: ./*.${{ inputs.package_extension }} | ||
| key: ${{ inputs.cache_key }} | ||
| fail-on-cache-miss: true | ||
|
|
||
| - if: ${{ inputs.package_extension == 'rpm' }} | ||
| name: Check packages installation / uninstallation | ||
| run: | | ||
| error_log="install_error_${{ inputs.distrib }}.log" | ||
| for package in ./*.rpm; do | ||
| echo "Installing package: $package" | ||
| # Install package, then uninstall it with all his dependencies | ||
| echo "Package installation..." | ||
| error_output=$(dnf install -y $package 2>&1) || { echo "$error_output" >> $error_log; echo "Error during installation of the package $package" >> $error_log; true; } | ||
| echo "Package installation done." | ||
| pack_name=$(echo $package | sed 's/\.\///' | sed 's/-[0-9\.-]*.el[0-9]*..*.rpm//') | ||
| if [[ -f ./tests/packaging/$pack_name.lua ]]; then | ||
| echo "Testing package..." | ||
| error_output=$(lua tests/packaging/$pack_name.lua 2>&1) || { echo "$error_output" >> $error_log; echo "Error during the usage test of the package $package" >> $error_log; true; } | ||
| echo "Testing done." | ||
| else | ||
| echo "No test script found for the package $package" | ||
| fi | ||
| echo "Package uninstallation..." | ||
| error_output=$(dnf autoremove --setopt=keepcache=True -y $pack_name 2>&1) || { echo "$error_output" >> $error_log; echo "Error during autoremove of the package $package" >> $error_log; true; } | ||
| echo "Package uninstallation done." | ||
| done | ||
| # If the file error_log exists and is not empty, the workflow is in error | ||
| if [[ -s $error_log ]]; then | ||
| cat $error_log | ||
| exit 1 | ||
| fi | ||
| shell: bash | ||
|
|
||
| - if: ${{ inputs.package_extension == 'deb' }} | ||
| name: Check packages installation / uninstallation | ||
| run: | | ||
| error_log="install_error_${{ inputs.distrib }}.log" | ||
| for package in ./*.deb; do | ||
| echo "Installing package: $package" | ||
| # Install package, then uninstall it with all his dependencies | ||
| echo "Package installation..." | ||
| error_output=$(apt-get install -y $package 2>&1) || { echo "$error_output" >> $error_log; echo "Error during installation of the package $package" >> $error_log; true; } | ||
| echo "Package installation done." | ||
| pack_name=$(echo $package | sed 's/\.\///' | sed 's/_[0-9\.-]*~[a-z]*_.*\.deb//') | ||
| if [[ -f ./tests/packaging/$pack_name.lua ]]; then | ||
| echo "Testing package..." | ||
| error_output=$(lua tests/packaging/$pack_name.lua 2>&1) || { echo "$error_output" >> $error_log; echo "Error during the usage test of the package $package" >> $error_log; true; } | ||
| echo "Testing done." | ||
| else | ||
| echo "No test script found for the package $package" | ||
| fi | ||
| echo "Package uninstallation..." | ||
| error_output=$(apt-get autoremove -y --purge $pack_name 2>&1) || { echo "$error_output" >> $error_log; echo "Error during autoremove of the package $package" >> $error_log; true; } | ||
| echo "Package uninstallation done." | ||
| done | ||
| # If the file error_log exists and is not empty, the workflow is in error | ||
| if [[ -s $error_log ]]; then | ||
| cat $error_log | ||
| exit 1 | ||
| fi | ||
| shell: bash |
2 changes: 1 addition & 1 deletion
2
.github/docker/Dockerfile.packaging-stream-connectors-nfpm-alma8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| ARG REGISTRY_URL | ||
| ARG REGISTRY_URL=docker.io | ||
|
|
||
| FROM ${REGISTRY_URL}/almalinux:8 | ||
|
|
||
|
|
||
2 changes: 1 addition & 1 deletion
2
.github/docker/Dockerfile.packaging-stream-connectors-nfpm-alma9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| ARG REGISTRY_URL | ||
| ARG REGISTRY_URL=docker.io | ||
|
|
||
| FROM ${REGISTRY_URL}/almalinux:9 | ||
|
|
||
|
|
||
2 changes: 1 addition & 1 deletion
2
.github/docker/Dockerfile.packaging-stream-connectors-nfpm-bookworm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| ARG REGISTRY_URL | ||
| ARG REGISTRY_URL=docker.centreon.com/centreon | ||
|
|
||
| FROM ${REGISTRY_URL}/debian:bookworm | ||
|
|
||
|
|
||
2 changes: 1 addition & 1 deletion
2
.github/docker/Dockerfile.packaging-stream-connectors-nfpm-bullseye
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| ARG REGISTRY_URL | ||
| ARG REGISTRY_URL=docker.centreon.com/centreon | ||
|
|
||
| FROM ${REGISTRY_URL}/debian:bullseye | ||
|
|
||
|
|
||
2 changes: 1 addition & 1 deletion
2
.github/docker/Dockerfile.packaging-stream-connectors-nfpm-jammy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| ARG REGISTRY_URL | ||
| ARG REGISTRY_URL=docker.centreon.com/centreon | ||
|
|
||
| FROM ${REGISTRY_URL}/ubuntu:jammy | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since the initial url is this https://github.com/centreon/centreon-stream-connector-scripts/blob/d1287cb06b89d96b420d3cff47b77e4ed69f1e67/.github/workflows/docker-packaging.yml#L48C11-L48C75
to avoid reaching the http calls quota at docker official registry, we may want to keep using the internal proxy
if this is to avoid the ARG error message, use the proxy url instead of docker official url