Redirect followup#1737
Merged
cert-manager-prow[bot] merged 7 commits intocert-manager:masterfrom Aug 13, 2025
Merged
Conversation
Contributor
jsoref
commented
Aug 12, 2025
jsoref
commented
- Follow up to Create redirects for cert-manager annotations #1696
cert-manager-prow
bot
added
dco-signoff: no
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
…main Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
…tations Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref
force-pushed
the
redirect-followup
branch
from
911f988 to
1c407c1
Compare
cert-manager-prow
bot
added
dco-signoff: yes
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
SgtCoDFish
reviewed
Aug 12, 2025
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref
force-pushed
the
redirect-followup
branch
from
05e5ffe to
aefa431
Compare
SgtCoDFish
approved these changes
Aug 13, 2025
Member
SgtCoDFish
left a comment
SgtCoDFish
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Looks like a clear improvement, thanks! I'll try a few of the redirects out once this is deployed 🚀
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
Contributor
Author
|
I tried all of the links and they work. A few items need some love because I had no idea what things meant, but I'll leave that to later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.