Issue deprecation warnings when calling objects that use pyopenssl in their signatures#206
Closed
ohemorange wants to merge 3 commits intomainfrom
Closed
Issue deprecation warnings when calling objects that use pyopenssl in their signatures#206ohemorange wants to merge 3 commits intomainfrom
ohemorange wants to merge 3 commits intomainfrom
Conversation
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're going to have to make breaking changes post-2.0 no matter what due to things like
x5cinjws. Assuming we go down the route of using the style of changes in #182 and just making a clean break, here are deprecation warnings so that users are aware of the upcoming transition. I used the same message in each place since we don't actually have a finalized PR with the changes we will make. If we do want more specific messages, we should have a reviewed PR ready so that the messages about what the changes will be are accurate.edit: #197 is a more recent PR. it's similar to #182, though it doesn't remove
ComparableX509. It may be easier to build off of.