Skip to content

Conversation

@cpq
Copy link
Member

@cpq cpq commented Jan 23, 2026

No description provided.

@cpq cpq requested a review from scaprile January 23, 2026 19:15
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please respect the Makefile standard, that is why tests are failing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@cpq cpq force-pushed the ota branch 2 times, most recently from 279a7ab to 4ff581a Compare January 24, 2026 10:19
// The rpc_ota_update() function handles those requests and calls Mongoose
// ota_begin(), ota_write(), ota_end() respectively.
//
// Visit https://mongoose.ws/mqtt/ web page to push the firmware binary.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will stimulate most users to peruse our broker for their personal stuff, I suggest they use a public broker instead, because, besides that, many of our tests rely on this broker.

MG_INFO(("%lu CONNECTED", c->id));
subscribe(c, mg_str(MQTT_RX_TOPIC));
} else if (ev == MG_EV_MQTT_MSG) {
// When we get echo response, print it
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover

Comment on lines +99 to +105
static void timer_sntp(void *param) { // SNTP timer function. Sync up time
static uint64_t hourly_timer = 0;
uint64_t t1 = mg_now(), t2 = mg_millis();
if (t1 < t2 + 3600 || mg_timer_expired(&hourly_timer, 3600000, t2)) {
mg_sntp_connect(param, "udp://time.google.com:123", NULL, NULL);
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This complicates the example, that is already complicated by the use of RPC instead of just going for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants