🐛 fix: Remove Plugin Test Dependencies#1488
Open
adambkaplan wants to merge 2 commits intochains-project:mainfrom
Open
🐛 fix: Remove Plugin Test Dependencies#1488adambkaplan wants to merge 2 commits intochains-project:mainfrom
adambkaplan wants to merge 2 commits intochains-project:mainfrom
Conversation
7e3c0ed to
532cd9f
Compare
Contributor
Author
Contributor
Author
532cd9f to
26aed9c
Compare
Use an ArtifactFilter to only include compile and runtime scope dependencies. This will exclude all test scope dependencies in the plugin dependency graph. Maven requires plugins to have their compile and runtime dependency tree present in the local Maven repository in order to function. Assisted-by: Cursor Signed-off-by: Adam Kaplan <adam.kaplan@redhat.com>
26aed9c to
1f63feb
Compare
Member
|
Thanks @adambkaplan ! Will be happy to merge this, however, there is a problem related when the user overwrites the plugin dependencies which could change the scope. Thus if the user changes the scope, a test dependency might get filtered out, even though its a different scope and should be included. <plugin>
<groupId>org.codehaus.gmavenplus</groupId>
<artifactId>gmavenplus-plugin</artifactId>
<version>4.2.1</version>
<inherited>false</inherited>
<dependencies>
<dependency>
<groupId>org.apache.groovy</groupId>
<artifactId>groovy</artifactId>
<version>5.0.3</version>
<scope>runtime</scope>
</dependency>
</dependencies>
<executions>
....
</executions>
</plugin>
I have added a commit to this branch with a suggestion to solve it. If you have time to review the code and it looks good we can merge. Otherwise feel free to remove my commit entirely if you prefer some alternative solution :) |
This was referenced Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use an ArtifactFilter to only include compile and runtime scope dependencies. This will exclude all test scope dependencies in the plugin dependency graph. Maven requires plugins to have their compile and runtime dependency tree present in the local Maven repository in order to function.
Fixes #1445