Clamp drag rectangle to chart area #896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this is a better UI, and it also fixes some issues with incorrect zoom ranges when dragging the rectangle outside of the chart area. To help implement this, I copied the clamp helper function from chartjs-plugin-annotation. Fixes chartjs#895
kurkle
reviewed
Nov 21, 2024
Member
kurkle
left a comment
kurkle
left a comment
There was a problem hiding this comment.
A test would be good to prevent regressions in the future 🙂
Contributor
Author
|
@kurkle Done. |
joshkel
force-pushed
the
drag-outside-chart-area
branch
from
cf52bda to
293d472
Compare
joshkel
force-pushed
the
drag-outside-chart-area
branch
from
293d472 to
36fe2c2
Compare
kurkle
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is a better UI, and it also fixes some issues with incorrect zoom ranges when dragging the rectangle outside of the chart area.
To help implement this, I copied the clamp helper function from chartjs-plugin-annotation.
Fixes #895