Issue #50: Register the Header in recipe registry #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
changes:
|
timurt
reviewed
Jul 22, 2025
Collaborator
timurt
left a comment
timurt
left a comment
There was a problem hiding this comment.
Minor comments from my side
src/main/java/org/checkstyle/autofix/CheckstyleRecipeRegistry.java
Outdated
Show resolved
Hide resolved
src/main/java/org/checkstyle/autofix/CheckstyleRecipeRegistry.java
Outdated
Show resolved
Hide resolved
Anmol202005
force-pushed
the
registryimpl
branch
from
18e2ff7 to
52d2958
Compare
Collaborator
Author
|
@timurt ping |
rdiachenko
reviewed
Jul 24, 2025
src/test/java/org/checkstyle/autofix/CheckstyleRecipeRegistryTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/checkstyle/autofix/parser/CheckConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/org/checkstyle/autofix/CheckstyleRecipeRegistry.java
Outdated
Show resolved
Hide resolved
timurt
approved these changes
Jul 25, 2025
Collaborator
timurt
left a comment
timurt
left a comment
There was a problem hiding this comment.
LGTM from my side
Thank you!
Anmol202005
force-pushed
the
registryimpl
branch
from
52d2958 to
3928fcf
Compare
rdiachenko
requested changes
Jul 25, 2025
src/main/java/org/checkstyle/autofix/CheckstyleRecipeRegistry.java
Outdated
Show resolved
Hide resolved
Anmol202005
force-pushed
the
registryimpl
branch
2 times, most recently
from
10788b2 to
d564d17
Compare
Collaborator
Author
|
@rdiachenko done. |
rdiachenko
reviewed
Jul 28, 2025
src/main/java/org/checkstyle/autofix/CheckstyleRecipeRegistry.java
Outdated
Show resolved
Hide resolved
Anmol202005
force-pushed
the
registryimpl
branch
3 times, most recently
from
79dfd2c to
0ac8465
Compare
Anmol202005
force-pushed
the
registryimpl
branch
from
0ac8465 to
324eccb
Compare
rdiachenko
approved these changes
Jul 30, 2025
Member
rdiachenko
left a comment
rdiachenko
left a comment
There was a problem hiding this comment.
It is not ideal:
createRecipecould return optional instead of nullif (check.isPresent())could be replaced with more readable stream api likecheck.ifPresent
But we already spent too much time on this PR, and it blocks further progress. I'm ok to merge it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #50
Implemented Header recipe in recipe registry